mirror of
https://github.com/go-gitea/gitea.git
synced 2024-11-19 00:54:29 +01:00
716fcfcf72
A lot of our code is repeatedly testing if individual errors are specific types of Not Exist errors. This is repetitative and unnecesary. `Unwrap() error` provides a common way of labelling an error as a NotExist error and we can/should use this. This PR has chosen to use the common `io/fs` errors e.g. `fs.ErrNotExist` for our errors. This is in some ways not completely correct as these are not filesystem errors but it seems like a reasonable thing to do and would allow us to simplify a lot of our code to `errors.Is(err, fs.ErrNotExist)` instead of `package.IsErr...NotExist(err)` I am open to suggestions to use a different base error - perhaps `models/db.ErrNotExist` if that would be felt to be better. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: delvh <dev.lh@web.de> |
||
|---|---|---|
| .. | ||
| archiver.go | ||
| attachment_test.go | ||
| attachment.go | ||
| avatar.go | ||
| collaboration_test.go | ||
| collaboration.go | ||
| fork_test.go | ||
| fork.go | ||
| git.go | ||
| issue.go | ||
| language_stats.go | ||
| main_test.go | ||
| mirror.go | ||
| pushmirror_test.go | ||
| pushmirror.go | ||
| redirect_test.go | ||
| redirect.go | ||
| release.go | ||
| repo_indexer.go | ||
| repo_list_test.go | ||
| repo_list.go | ||
| repo_test.go | ||
| repo_unit.go | ||
| repo.go | ||
| star_test.go | ||
| star.go | ||
| topic_test.go | ||
| topic.go | ||
| update.go | ||
| upload.go | ||
| user_repo_test.go | ||
| user_repo.go | ||
| watch_test.go | ||
| watch.go | ||
| wiki_test.go | ||
| wiki.go | ||