mirror/gitea
1
1
Fork 1
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-27 05:22:12 +01:00
Code Issues
main
gitea/modules
History
Copilot a3cc34472b
Pass ServeHeaderOptions by value instead of pointer, fine tune httplib tests (#36982) 
Pass `ServeHeaderOptions` by value instead of pointer across all call
sites — no nil-check semantics are needed and the struct is small enough
that copying is fine.

## Changes

- **`services/context/base.go`**: `SetServeHeaders` and `ServeContent`
accept `ServeHeaderOptions` (value, not pointer); internal unsafe
pointer cast replaced with a clean type conversion
- **`routers/api/packages/helper/helper.go`**: `ServePackageFile`
variadic changed from `...*context.ServeHeaderOptions` to
`...context.ServeHeaderOptions`; internal variable is now a value type
- **All call sites** (13 files): `&context.ServeHeaderOptions{...}` →
`context.ServeHeaderOptions{...}`

Before/after at the definition level:
```go
// Before
func (b *Base) SetServeHeaders(opt *ServeHeaderOptions) { ... }
func (b *Base) ServeContent(r io.ReadSeeker, opts *ServeHeaderOptions) { ... }
func ServePackageFile(..., forceOpts ...*context.ServeHeaderOptions) { ... }

// After
func (b *Base) SetServeHeaders(opts ServeHeaderOptions) { ... }
func (b *Base) ServeContent(r io.ReadSeeker, opts ServeHeaderOptions) { ... }
func ServePackageFile(..., forceOpts ...context.ServeHeaderOptions) { ... }
```

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: wxiaoguang <2114189+wxiaoguang@users.noreply.github.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2026-03-25 16:07:59 -07:00
..
actions Feature non-zipped actions artifacts (action v7) (#36786) 2026-03-26 00:37:48 +08:00
analyze Fix incorrect vendored detections (#36508) 2026-02-01 10:35:51 +00:00
assetfs Refactor avatar package, support default avatar fallback (#36788) 2026-03-01 13:32:35 +00:00
auth Correct spelling (#36783) 2026-02-28 11:23:20 -08:00
avatar Refactor avatar package, support default avatar fallback (#36788) 2026-03-01 13:32:35 +00:00
badge Add flat-square action badge style (#34062) 2025-04-01 09:42:10 +00:00
base Fix incorrect setting loading order (#36735) 2026-02-24 23:46:08 +08:00
cache enforce explanation for necessary nolints and fix bugs (#34883) 2025-06-27 21:48:03 +08:00
cachegroup Cache GPG keys, emails and users when list commits (#34086) 2025-04-09 16:34:38 +00:00
charset Fix CodeQL code scanning alerts (#36858) 2026-03-08 14:35:50 +00:00
commitstatus enforce nolint scope (#34851) 2025-06-27 07:59:55 +02:00
container Refactor sidebar assignee&milestone&project selectors (#32465) 2024-11-11 04:07:54 +08:00
csv Disable Field count validation of CSV viewer (#35228) 2025-09-04 09:54:58 -07:00
dump Use github.com/mholt/archives replace github.com/mholt/archiver (#35390) 2025-09-01 19:40:12 +00:00
emoji Update emoji data for Unicode 16 (#36596) 2026-02-12 21:39:36 +00:00
eventsource Add more check for stopwatch read or list (#36340) 2026-01-13 13:13:39 +00:00
fileicon Add FOLDER_ICON_THEME configuration option (#36496) 2026-01-30 20:48:56 +00:00
generate
git Add a git grep search timeout (#36809) 2026-03-04 12:11:42 -08:00
gitrepo Clean up Makefile, tests and legacy code (#36638) 2026-02-19 01:23:32 +00:00
glob Replace gobwas/glob package (#35478) 2025-09-13 18:01:00 +00:00
globallock Upgrade golang to 1.25.1 and add descriptions for the swagger structs' fields (#35418) 2025-09-06 16:52:41 +00:00
graceful Enable nilnil linter for new code (#36591) 2026-02-16 09:57:18 +00:00
gtprof Add start time on perf trace because it seems some steps haven't been recorded. (#35282) 2025-08-18 15:17:19 +00:00
hcaptcha Clean up Makefile, tests and legacy code (#36638) 2026-02-19 01:23:32 +00:00
highlight Fix chroma lexer mapping (#36629) 2026-02-16 02:11:02 +00:00
hostmatcher Run gopls modernize on codebase (#34751) 2025-06-18 01:48:09 +00:00
htmlutil Fix markup heading parsing, fix emphasis parsing (#36284) 2026-01-23 20:24:58 +00:00
httpcache Refactor avatar package, support default avatar fallback (#36788) 2026-03-01 13:32:35 +00:00
httplib Pass ServeHeaderOptions by value instead of pointer, fine tune httplib tests (#36982) 2026-03-25 16:07:59 -07:00
indexer Fix typos in code comments: doesnt, dont, wont (#36890) 2026-03-13 09:58:44 -07:00
issue/template Limit reading bytes instead of ReadAll (#35928) 2025-11-12 19:44:49 +08:00
json Drop json-iterator dependency (#35544) 2025-09-28 22:30:28 +08:00
label Run gopls modernize on codebase (#34751) 2025-06-18 01:48:09 +00:00
lfs Feature non-zipped actions artifacts (action v7) (#36786) 2026-03-26 00:37:48 +08:00
lfstransfer Correct spelling (#36783) 2026-02-28 11:23:20 -08:00
log Refactor git command context & pipeline (#36406) 2026-01-21 01:35:14 +00:00
markup Fix various trivial problems (#36921) 2026-03-19 07:13:55 +08:00
mcaptcha
metrics Remove incorrect "db.DefaultContext" usages (#35366) 2025-08-28 03:52:43 +00:00
migration fix: prevent panic when GitLab release has more links than sources (#36295) 2026-01-05 21:48:12 +08:00
nosql Refactor git command context & pipeline (#36406) 2026-01-21 01:35:14 +00:00
optional Fix API not persisting pull request unit config when has_pull_requests is not set (#36718) 2026-03-02 22:08:53 +00:00
options Refactor embedded assets and drop unnecessary dependencies (#34692) 2025-06-12 03:59:33 +00:00
packages Refactor storage content-type handling of ServeDirectURL (#36804) 2026-03-21 21:26:13 -07:00
paginator Only use prev and next buttons for pagination on user dashboard (#33981) 2025-03-23 19:52:43 +00:00
pprof
private feat: Add configurable permissions for Actions automatic tokens (#36173) 2026-03-21 15:39:47 -07:00
process Refactor git command context & pipeline (#36406) 2026-01-21 01:35:14 +00:00
proxy Replace gobwas/glob package (#35478) 2025-09-13 18:01:00 +00:00
proxyprotocol Enable addtional linters (#34085) 2025-04-01 10:14:01 +00:00
public Refactor storage content-type handling of ServeDirectURL (#36804) 2026-03-21 21:26:13 -07:00
queue Refactor git command context & pipeline (#36406) 2026-01-21 01:35:14 +00:00
recaptcha Fix URLJoin, markup render link reoslving, sign-in/up/linkaccount page common data (#36861) 2026-03-08 15:57:37 +00:00
references Support closing keywords with URL references (#36221) 2025-12-27 09:05:24 -08:00
regexplru Enable testifylint rules (#34075) 2025-03-31 01:53:48 -04:00
repository feat: Add configurable permissions for Actions automatic tokens (#36173) 2026-03-21 15:39:47 -07:00
reqctx Run gopls modernize on codebase (#34751) 2025-06-18 01:48:09 +00:00
secret Upgrade golangci-lint to v1.64.5 (#33654) 2025-02-21 00:05:40 +08:00
session Clean up Makefile, tests and legacy code (#36638) 2026-02-19 01:23:32 +00:00
setting Make PUBLIC_URL_DETECTION default to "auto" (#36955) 2026-03-23 23:19:08 +00:00
sitemap
ssh Update x/crypto package and make builtin SSH use default parameters (#34667) 2025-06-09 19:51:02 +00:00
storage Feature non-zipped actions artifacts (action v7) (#36786) 2026-03-26 00:37:48 +08:00
structs Fix org contact email not clearable once set (#36975) 2026-03-25 15:23:11 +08:00
svg Add render cache for SVG icons (#36863) 2026-03-10 05:26:16 +00:00
system Remove incorrect "db.DefaultContext" usages (#35366) 2025-08-28 03:52:43 +00:00
tailmsg Support performance trace (#32973) 2025-01-21 18:57:07 +00:00
tempdir Address some CodeQL security concerns (#35572) 2025-10-04 01:21:26 +08:00
templates Fix URLJoin, markup render link reoslving, sign-in/up/linkaccount page common data (#36861) 2026-03-08 15:57:37 +00:00
test Require additional user confirmation for making repo private (#36959) 2026-03-24 20:13:08 +00:00
testlogger Clean up Makefile, tests and legacy code (#36638) 2026-02-19 01:23:32 +00:00
timeutil Clean up Makefile, tests and legacy code (#36638) 2026-02-19 01:23:32 +00:00
translation Fix various trivial problems (#36953) 2026-03-23 18:23:42 +00:00
turnstile
typesniffer Feature non-zipped actions artifacts (action v7) (#36786) 2026-03-26 00:37:48 +08:00
updatechecker Enable addtional linters (#34085) 2025-04-01 10:14:01 +00:00
uri
user Refactor older tests to use testify (#33140) 2025-01-09 09:21:47 +08:00
util feat: Add configurable permissions for Actions automatic tokens (#36173) 2026-03-21 15:39:47 -07:00
validation Add user badges (#36752) 2026-03-22 15:49:45 +00:00
web Add user badges (#36752) 2026-03-22 15:49:45 +00:00
webhook actions: report commit status for pull_request_review events (#36589) 2026-02-20 16:12:22 +00:00
zstd Refactor embedded assets and drop unnecessary dependencies (#34692) 2025-06-12 03:59:33 +00:00