chore: update default version #9916
Conversation
sapk
added
type/miscellaneous
skip-changelog
GiteaBot
added
the
lgtm/need 1
main.go
Outdated
| @@ -29,7 +29,7 @@ import ( | |||
|
|
|||
| var ( | |||
| // Version holds the current Gitea version | |||
| Version = "1.9.0-dev" | |||
| Version = "1.12.0-dev" | |||
There was a problem hiding this comment.
I think it would be better if we have this set to 0.0.0-dev, as we have our makefile override this, and then we could also distinguish better when the binary is built via go build without version info passedin.
There was a problem hiding this comment.
-dev is already specific to direct build ?
There was a problem hiding this comment.
or maybe have it blank like the below variables?
|
@techknowlogick we had this topic before ... #8686 |
|
@6543 I just don't think this should have to be kept up to date, as makefile already gives us the info. Having it be a non version would prevent users from being confused when we don't update this line. My opinion is still the same as the other PR you made. |
|
Maybe it is time for a vote ?
(emojis are just listed by order and doesn't means anythings) Edit: add development |
Codecov Report
@@ Coverage Diff @@
## master #9916 +/- ##
=======================================
Coverage 42.27% 42.27%
=======================================
Files 610 610
Lines 80370 80370
=======================================
Hits 33978 33978
- Misses 42208 42210 +2
+ Partials 4184 4182 -2
Continue to review full report at Codecov.
|
|
@go-gitea/maintainers vote: #9916 (comment) |
GiteaBot
added
lgtm/done
|
The version is some meaning when you download the tar zip source file. Because there is no git commit information to let you know what's the version of this source copy. |
|
What @lunny has said makes sense. I've taken away my block. |
|
Based on the related issue I would actually argue against updating this value unless we plan on doing so for every release. |
|
How about "built from sources", "please build using make" or "don't bother, it's not relevant" 🤣 No, really, some text that implies that it was built outside of the normal build flow. |
|
@guillep2k that’s why I had suggested 0.0.0-dev previously |
|
The -dev flag imply that it was build without make. I think it is good to close some old debat that was put aside and clear them by a vote by maintainers and not stay with a status quo. |
Co-Authored-By: 6543 <6543@obermui.de>
|
@guillep2k Maybe set to something ironic, like "did-you-make-it?" |
|
For drone plugins im setting it to unknown by default |
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
|
@sapk is core not chore or ? |
|
I used |
|
I believe we need to set AppVer to valid version string now. See:
Or, is there any better way to avoid AppVer appearing in many unit tests? |
I know that the version is generate in makefile but it would be good to keep it up-to-date from time to time.
Related #9913