fix bug about wrong dependencies permissions check and other wrong permissions check #9884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
approved these changes
Jan 20, 2020
GiteaBot
added
the
lgtm/need 1
guillep2k
approved these changes
Jan 20, 2020
GiteaBot
added
lgtm/done
lunny
force-pushed
the
lunny/fix_dependcies3
branch
from
69f5290
to
fe27e0b
Compare
sapk
approved these changes
Jan 20, 2020
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Feb 16, 2020
lafriks
pushed a commit
that referenced
this pull request
Feb 16, 2020
* v1.10.4 Changelog * Add backport identifier for #10261 * Update CHANGELOG.md entry for #9884 * Workaround docker-library/postgres#658 * Update .drone.yml
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Feb 16, 2020
* v1.10.4 Changelog * Add backport identifier for go-gitea#10261 * Update CHANGELOG.md entry for go-gitea#9884
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Feb 16, 2020
* v1.10.4 Changelog * Add backport identifier for go-gitea#10261 * Update CHANGELOG.md entry for go-gitea#9884
techknowlogick
pushed a commit
that referenced
this pull request
Feb 16, 2020
techknowlogick
pushed a commit
that referenced
this pull request
Feb 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially backport #9842 and fix more wrong issue permission check.
Hint: If a page or an API is shared by issue and pullrequest, you must use
CanWriteIssuesOrPulls(issue.IsPull)but notCanWrite(models.UnitTypeIssues)to check the permisson.