Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation for the go module era #9751

Merged
merged 12 commits into from Jan 29, 2020
Merged

Update documentation for the go module era #9751

merged 12 commits into from Jan 29, 2020

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Jan 13, 2020 •
edited

Calculates GOPATH using $(shell $(GO) env GOPATH)

Update instructions to just use git clone

Slight update to readme

@zeripath zeripath added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Jan 13, 2020
@zeripath zeripath added this to the 1.12.0 milestone Jan 13, 2020
@codecov-io
Copy link

codecov-io commented Jan 13, 2020 •
edited

Codecov Report

Merging #9751 into master will decrease coverage by <.01%.
The diff coverage is 40.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9751      +/-   ##
==========================================
- Coverage   42.26%   42.25%   -0.01%     
==========================================
  Files         610      616       +6     
  Lines       80370    80742     +372     
==========================================
+ Hits        33968    34119     +151     
- Misses      42225    42421     +196     
- Partials     4177     4202      +25
Impacted Files Coverage Δ
modules/options/options.go 96.15% <ø> (ø) ⬆️
modules/public/public.go 74.41% <ø> (ø) ⬆️
models/list_options.go 57.89% <ø> (ø) ⬆️
models/pull_sign.go 34.86% <0%> (ø) ⬆️
routers/private/manager.go 0% <0%> (ø)
modules/migrations/gitea.go 6.14% <0%> (-0.02%) ⬇️
routers/private/manager_unix.go 0% <0%> (ø)
cmd/manager.go 0% <0%> (ø)
routers/repo/pull.go 28.7% <0%> (-0.37%) ⬇️
modules/graceful/manager_unix.go 40.83% <0%> (-2.53%) ⬇️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4f5935...54aca61. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 13, 2020
@zeripath
Update documentation for the go module era
4d4dea4 
use go env instead of $GOPATH

Update instructions to just use git clone

Slight update to readme

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath changed the title use go env instead of $GOPATH Update documentation for the go module era Jan 13, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 13, 2020
@bagasme bagasme mentioned this pull request Jan 14, 2020
Closed
zeripath and others added 2 commits January 15, 2020 19:12
@zeripath
Merge branch 'master' into makefile-changes
fa7ab48
@zeripath @sapk @bagasme
Apply suggestions from code review
b0cf977 
Co-Authored-By: Antoine GIRARD <sapk@users.noreply.github.com>
Co-Authored-By: Bagas Sanjaya <bagasdotme@gmail.com>
bagasme
bagasme approved these changes Jan 19, 2020
View reviewed changes
Copy link
Contributor

@bagasme bagasme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 19, 2020
@6543
Copy link
Member

6543 commented Jan 19, 2020

plz Update branch

zeripath
zeripath commented Jan 19, 2020
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@zeripath zeripath added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Jan 19, 2020
@zeripath zeripath removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Jan 25, 2020
@techknowlogick techknowlogick added the type/docs This PR mainly updates/creates documentation label Jan 29, 2020
@techknowlogick techknowlogick merged commit 82a9797 into go-gitea:master Jan 29, 2020
@silverwind silverwind mentioned this pull request Feb 1, 2020
Closed
@zeripath zeripath deleted the makefile-changes branch February 28, 2020 17:19
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind left review comments

@sapk sapk sapk left review comments

@lunny lunny lunny approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

@6543 6543 6543 approved these changes

@bagasme bagasme bagasme approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@zeripath @codecov-io @6543 @lunny @silverwind @techknowlogick @sapk @bagasme @GiteaBot