Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] [API] ​/repos​/issues​/search #9698

Merged
merged 7 commits into from Jan 12, 2020
Merged

[BugFix] [API] ​/repos​/issues​/search #9698

merged 7 commits into from Jan 12, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Jan 11, 2020

close #9677

unauthentificated users now can use this function too but only for public repos

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 11, 2020
@codecov-io
Copy link

codecov-io commented Jan 11, 2020 •
edited

Codecov Report

Merging #9698 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9698      +/-   ##
==========================================
- Coverage   42.29%   42.29%   -0.01%     
==========================================
  Files         592      592              
  Lines       78159    78159              
==========================================
- Hits        33058    33054       -4     
- Misses      41052    41055       +3     
- Partials     4049     4050       +1
Impacted Files Coverage Δ
modules/avatar/avatar.go 48% <0%> (-6%) ⬇️
models/unit.go 62.16% <0%> (-5.41%) ⬇️
modules/process/manager.go 74.69% <0%> (-3.62%) ⬇️
routers/repo/view.go 38.59% <0%> (-0.88%) ⬇️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️
services/pull/check.go 50.67% <0%> (+2.02%) ⬆️
services/pull/temp_repo.go 34.18% <0%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e69ca8c...60ed0c2. Read the comment docs.

@lunny lunny added this to the 1.12.0 milestone Jan 11, 2020
@lunny
Copy link
Member

lunny commented Jan 11, 2020

@6543 It's better to add some integration tests.

@6543
Copy link
Member Author

6543 commented Jan 11, 2020

@lunny done

@lafriks
Copy link
Member

lafriks commented Jan 11, 2020

Would be good to add test case also for anonymous user

@6543
Copy link
Member Author

6543 commented Jan 11, 2020

@lafriks is already here: https://github.com/go-gitea/gitea/pull/9698/files#diff-ce762c7d04cc2cff7a58d2e17c19410aR133

@6543
Copy link
Member Author

6543 commented Jan 11, 2020

@zeripath @lafriks can this fix go in now?

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 11, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 11, 2020
@lunny lunny merged commit 83f9359 into go-gitea:master Jan 12, 2020
@lunny
Copy link
Member

lunny commented Jan 12, 2020

Please send back port.

@6543 6543 deleted the bug-fix-api branch January 12, 2020 09:08
6543 added a commit to 6543-forks/gitea that referenced this pull request Jan 12, 2020
@6543 @sapk
[BugFix] [API] ​/repos​/issues​/search (go-gitea#9698)
cf852f5 
* fix

* fix options

* add TEST

Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com>
@6543 6543 mentioned this pull request Jan 12, 2020
Merged
@6543
Copy link
Member Author

6543 commented Jan 12, 2020

done -> #9724

zeripath pushed a commit that referenced this pull request Jan 12, 2020
@6543 @sapk @zeripath
[BugFix] [API] ​/repos​/issues​/search (#9698) (#9724)
dbeef6b 
* fix

* fix options

* add TEST

Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com>

Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com>
@zeripath zeripath added the backport/done All backports for this PR have been created label Jan 12, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

[Bug] [API] ​/repos​/issues​/search
7 participants
@6543 @codecov-io @lunny @lafriks @zeripath @GiteaBot @sapk