Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove google font call #9668

Merged
merged 3 commits into from
Jan 9, 2020
Merged

Conversation

techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Jan 9, 2020

As title

Edit: I know this edits the vendor'd lib, however there is no other way to remove this (until we move to the other PR where it is managed by npm)

@techknowlogick techknowlogick added this to the 1.12.0 milestone Jan 9, 2020
@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Jan 9, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 9, 2020
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine until we land #9561

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 9, 2020
@codecov-io
Copy link

codecov-io commented Jan 9, 2020

Codecov Report

Merging #9668 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9668      +/-   ##
==========================================
- Coverage   42.26%   42.25%   -0.02%     
==========================================
  Files         587      587              
  Lines       77987    77987              
==========================================
- Hits        32959    32950       -9     
- Misses      40988    40996       +8     
- Partials     4040     4041       +1
Impacted Files Coverage Δ
models/repo_mirror.go 2.12% <0%> (-10.64%) ⬇️
services/pull/check.go 53.52% <0%> (-0.71%) ⬇️
services/mirror/mirror.go 18.75% <0%> (-0.66%) ⬇️
models/pull.go 45.77% <0%> (-0.48%) ⬇️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2de97e3...df4339e. Read the comment docs.

@techknowlogick techknowlogick merged commit 8f31c2f into go-gitea:master Jan 9, 2020
@techknowlogick techknowlogick deleted the remove-google branch January 9, 2020 20:48
techknowlogick added a commit to techknowlogick/gitea that referenced this pull request Jan 9, 2020
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Jan 9, 2020
techknowlogick added a commit that referenced this pull request Jan 9, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants