Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move wiki related funtions from models to services/wiki #9355

Merged
merged 11 commits into from
Jan 7, 2020
Merged

Move wiki related funtions from models to services/wiki #9355

merged 11 commits into from
Jan 7, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 14, 2019

As title.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Dec 14, 2019
@lunny lunny force-pushed the lunny/move_wiki branch 4 times, most recently from c0b6ecf to 243d02a Compare December 16, 2019 00:56
@codecov-io
Copy link

codecov-io commented Dec 16, 2019 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@5749b26). Click here to learn what that means.
The diff coverage is 58.82%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9355   +/-   ##
=========================================
  Coverage          ?   42.14%           
=========================================
  Files             ?      579           
  Lines             ?    76071           
  Branches          ?        0           
=========================================
  Hits              ?    32063           
  Misses            ?    40025           
  Partials          ?     3983
Impacted Files Coverage Δ
models/wiki.go 100% <ø> (ø)
routers/private/serv.go 33.33% <0%> (ø)
services/wiki/wiki.go 57.08% <57.08%> (ø)
routers/repo/wiki.go 38.88% <80.95%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5749b26...98db2fb. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 16, 2019
@6543
Copy link
Member

6543 commented Dec 18, 2019 •
edited

Wow - thanks for optimisations :D

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 18, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 7, 2020
@6543
Copy link
Member

6543 commented Jan 7, 2020

Think ths should go into 1.11.0 ... so we dint differ to mouch with codebase from 1.11.0 to 1.12.0

@lafriks lafriks added this to the 1.11.0 milestone Jan 7, 2020
@zeripath
Copy link
Contributor

zeripath commented Jan 7, 2020

Make lg-tm work

@zeripath zeripath merged commit b9309e5 into go-gitea:master Jan 7, 2020
@lunny lunny deleted the lunny/move_wiki branch January 8, 2020 00:30
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@guillep2k guillep2k guillep2k approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@lunny @codecov-io @6543 @zeripath @lafriks @guillep2k @GiteaBot