New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix datarace on git.GlobalCommandArgs on tests #9162
Conversation
If the reason to constantly change the global options is that some commands require LFS settings and some commands don't, isn't it better to simply have two sets of global options? |
@guillep2k so in the git_test we create some LFS files as a client. We want the LFS filters to run to install them into the client repository that we are going to push to Gitea. That is the only reason for changing the filters. |
@guillep2k Only a little git commands need that changes, so I think that's unnecessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from name suggestion this lgtm
Codecov Report
@@ Coverage Diff @@
## master #9162 +/- ##
==========================================
+ Coverage 41.01% 41.03% +0.01%
==========================================
Files 553 553
Lines 72026 72041 +15
==========================================
+ Hits 29545 29562 +17
+ Misses 38750 38747 -3
- Partials 3731 3732 +1
Continue to review full report at Codecov.
|
make l-gtm work |
Should be part of #1441