Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix datarace on git.GlobalCommandArgs on tests #9162

Merged
merged 5 commits into from Nov 27, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 26, 2019

Should be part of #1441

@guillep2k
Copy link
Member

If the reason to constantly change the global options is that some commands require LFS settings and some commands don't, isn't it better to simply have two sets of global options?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 26, 2019
@zeripath
Copy link
Contributor

@guillep2k so in the git_test we create some LFS files as a client. We want the LFS filters to run to install them into the client repository that we are going to push to Gitea. That is the only reason for changing the filters.

@lunny
Copy link
Member Author

lunny commented Nov 26, 2019

@guillep2k Only a little git commands need that changes, so I think that's unnecessary.

modules/git/command.go Outdated Show resolved Hide resolved
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from name suggestion this lgtm

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 26, 2019
@codecov-io
Copy link

Codecov Report

Merging #9162 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9162      +/-   ##
==========================================
+ Coverage   41.01%   41.03%   +0.01%     
==========================================
  Files         553      553              
  Lines       72026    72041      +15     
==========================================
+ Hits        29545    29562      +17     
+ Misses      38750    38747       -3     
- Partials     3731     3732       +1
Impacted Files Coverage Δ
modules/git/command.go 92% <100%> (+0.42%) ⬆️
modules/git/repo.go 45.11% <100%> (+1.04%) ⬆️
modules/git/commit.go 52.09% <100%> (+0.94%) ⬆️
models/unit.go 62.16% <0%> (-5.41%) ⬇️
modules/indexer/indexer.go 55.26% <0%> (+10.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 055f6d2...1826547. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 26, 2019
@sapk
Copy link
Member

sapk commented Nov 27, 2019

make l-gtm work

@sapk sapk merged commit 7b7d382 into go-gitea:master Nov 27, 2019
@lunny lunny deleted the lunny/fix_global_commands branch November 27, 2019 00:39
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants