Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename HookQueue to hookQueue #8778

Merged
merged 2 commits into from Nov 2, 2019
Merged

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 2, 2019

This PR renamed HookQueue to hookQueue so that external package will not visit it. And after this, webhook invokes will become just PrepareWebhooks or PrepareWebhook. go webhook_module.HookQueue.Add is unnecessary.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 2, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 2, 2019
@codecov-io
Copy link

codecov-io commented Nov 2, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@4b8d9e5). Click here to learn what that means.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8778   +/-   ##
=========================================
  Coverage          ?   41.36%           
=========================================
  Files             ?      541           
  Lines             ?    69477           
  Branches          ?        0           
=========================================
  Hits              ?    28741           
  Misses            ?    37053           
  Partials          ?     3683
Impacted Files Coverage Δ
services/pull/pull.go 39.79% <ø> (ø)
modules/notification/webhook/webhook.go 44.57% <ø> (ø)
modules/repofiles/action.go 63.69% <ø> (ø)
services/mirror/sync.go 0% <ø> (ø)
services/release/release.go 25.71% <ø> (ø)
routers/api/v1/repo/hook.go 18.39% <ø> (ø)
services/milestone/milestone.go 0% <ø> (ø)
routers/repo/pull.go 30.31% <ø> (ø)
routers/repo/webhook.go 1.38% <ø> (ø)
services/pull/merge.go 41.02% <ø> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b8d9e5...9817218. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 2, 2019
@lunny lunny merged commit f518fe6 into go-gitea:master Nov 2, 2019
@lunny lunny deleted the lunny/rename_hookqueue branch November 2, 2019 02:35
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants