Move labels webhooks to notification #8749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/refactoring
lunny
changed the title
6543
reviewed
Oct 30, 2019
services/issue/label.go
Outdated
| @@ -84,7 +36,7 @@ func AddLabels(issue *models.Issue, doer *models.User, labels []*models.Label) e | |||
| return err | |||
| } | |||
|
|
|||
| sendLabelUpdatedWebhook(issue, doer) | |||
| notification.NotifyIssueChangeLabels(doer, issue, nil, nil) | |||
There was a problem hiding this comment.
Suggested change
| notification.NotifyIssueChangeLabels(doer, issue, nil, nil) | |
| notification.NotifyIssueChangeLabels(doer, issue, labels, nil) |
why not use the new parameter - we can implement the handling at NotifyIssueChangeLabels later?
GiteaBot
added
the
lgtm/need 2
6543
reviewed
Oct 30, 2019
services/issue/label.go
Outdated
| @@ -74,7 +26,7 @@ func AddLabel(issue *models.Issue, doer *models.User, label *models.Label) error | |||
| return err | |||
| } | |||
|
|
|||
| sendLabelUpdatedWebhook(issue, doer) | |||
| notification.NotifyIssueChangeLabels(doer, issue, nil, nil) | |||
There was a problem hiding this comment.
Suggested change
| notification.NotifyIssueChangeLabels(doer, issue, nil, nil) | |
| notification.NotifyIssueChangeLabels(doer, issue, []*models.lable {label}, nil) |
same here ...
6543
reviewed
Oct 30, 2019
services/issue/label.go
Outdated
| @@ -106,6 +58,6 @@ func RemoveLabel(issue *models.Issue, doer *models.User, label *models.Label) er | |||
| return err | |||
| } | |||
|
|
|||
| sendLabelUpdatedWebhook(issue, doer) | |||
| notification.NotifyIssueChangeLabels(doer, issue, nil, nil) | |||
There was a problem hiding this comment.
Suggested change
| notification.NotifyIssueChangeLabels(doer, issue, nil, nil) | |
| notification.NotifyIssueChangeLabels(doer, issue, nil, []*models.lable {label}) |
same here ...
6543
approved these changes
Oct 30, 2019
GiteaBot
added
lgtm/need 1
|
@lunny optional changes aboth ... beside that approved :D |
Codecov Report
@@ Coverage Diff @@
## master #8749 +/- ##
==========================================
- Coverage 41.39% 41.38% -0.02%
==========================================
Files 541 541
Lines 69522 69522
==========================================
- Hits 28780 28772 -8
- Misses 37048 37056 +8
Partials 3694 3694
Continue to review full report at Codecov.
|
guillep2k
reviewed
Oct 31, 2019
| @@ -398,3 +398,50 @@ func (m *webhookNotifier) NotifyDeleteComment(doer *models.User, comment *models | |||
| go models.HookQueue.Add(comment.Issue.Repo.ID) | |||
| } | |||
| } | |||
|
|
|||
| func (m *webhookNotifier) NotifyIssueChangeLabels(doer *models.User, issue *models.Issue, | |||
There was a problem hiding this comment.
I see that ClearLabels() doesn't use this function. Is it a whole type of notification?
lunny
force-pushed
the
lunny/move_label_webhook
branch
from
05949d4
to
63d4987
Compare
|
@6543 all done. |
lunny
force-pushed
the
lunny/move_label_webhook
branch
from
63d4987
to
f923278
Compare
guillep2k
approved these changes
Nov 2, 2019
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.