Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The pagination result of commit history is incorrect #8716

Closed
2 of 7 tasks
yasuokav opened this issue Oct 28, 2019 · 4 comments · Fixed by #14831
Closed
2 of 7 tasks

The pagination result of commit history is incorrect #8716

yasuokav opened this issue Oct 28, 2019 · 4 comments · Fixed by #14831
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Milestone
1.13.3

Comments

@yasuokav
Copy link
Contributor

Description

Duplicate commits appear on each page

Screenshots

Page1:
1
Page5:
2
@lunny lunny added the type/bug label Nov 2, 2019
@stale
Copy link

stale bot commented Jan 1, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Jan 1, 2020
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Jan 1, 2020
@stale stale bot removed the issue/stale label Jan 1, 2020
@yasuokav
Copy link
Contributor Author

Gentle bump. This issue is still exists in 1.14.0+dev-253-g24330f71b

Gitea(https://try.gitea.io/yasuokav/gitea/commits/branch/master/models/action.go):

  • Page1
    1
  • Page2
    2

Github(https://github.com/go-gitea/gitea/commits/master/models/action.go):

  • Page1
    1
  • Page2
    2

@lunny
Copy link
Member

lunny commented Jan 28, 2021

The bug could be reproduced when visit a file's history but not commits of a branch.

@zeripath
Copy link
Contributor

ugh the issue is that the --skip argument doesn't work the expected way.

zeripath added a commit to zeripath/gitea that referenced this issue Feb 28, 2021
@zeripath
Fix paging of file commit logs
c56ad17 
Unfortunately `git log revision ... --skip=x -- path` skips the number of commits
not the number of commits relating to the path.

This PR changes the function to have a reader that reads and skips the
necessary number of commits by hand instead.

Fix go-gitea#8716

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this issue Feb 28, 2021
Merged
@zeripath zeripath added this to the 1.13.3 milestone Mar 2, 2021
lafriks pushed a commit that referenced this issue Mar 4, 2021
@zeripath @6543
Fix paging of file commit logs (#14831)
59d1cc4 
Unfortunately `git log revision ... --skip=x -- path` skips the number of commits
not the number of commits relating to the path.

This PR changes the function to have a reader that reads and skips the
necessary number of commits by hand instead.

Fix #8716

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: 6543 <6543@obermui.de>
zeripath added a commit to zeripath/gitea that referenced this issue Mar 4, 2021
@zeripath @6543
Fix paging of file commit logs (go-gitea#14831)
d4c7f35 
Backport go-gitea#14831

Unfortunately `git log revision ... --skip=x -- path` skips the number of commits
not the number of commits relating to the path.

This PR changes the function to have a reader that reads and skips the
necessary number of commits by hand instead.

Fix go-gitea#8716

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: 6543 <6543@obermui.de>
@zeripath zeripath mentioned this issue Mar 4, 2021
Merged
lunny pushed a commit that referenced this issue Mar 4, 2021
@zeripath @6543
Fix paging of file commit logs (#14831) (#14879)
e663f74 
Backport #14831

Unfortunately `git log revision ... --skip=x -- path` skips the number of commits
not the number of commits relating to the path.

This PR changes the function to have a reader that reads and skips the
necessary number of commits by hand instead.

Fix #8716

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: 6543 <6543@obermui.de>

Co-authored-by: 6543 <6543@obermui.de>
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Milestone
1.13.3
Development

Successfully merging a pull request may close this issue.

Fix paging of file commit logs zeripath/gitea
3 participants
@lunny @zeripath @yasuokav