Upgrade xorm to latest to fix insert issue bug #8309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8309 +/- ##
==========================================
+ Coverage 41.52% 41.53% +<.01%
==========================================
Files 494 494
Lines 65384 65384
==========================================
+ Hits 27151 27155 +4
+ Misses 34737 34733 -4
Partials 3496 3496
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
guillep2k
suggested changes
Sep 28, 2019
| @@ -824,3 +824,5 @@ xorm.io/builder v0.3.6 h1:ha28mQ2M+TFx96Hxo+iq6tQgnkC9IZkM6D8w9sKHHF8= | |||
| xorm.io/builder v0.3.6/go.mod h1:LEFAPISnRzG+zxaxj2vPicRwz67BdhFreKg8yv8/TgU= | |||
| xorm.io/core v0.7.0 h1:hKxuOKWZNeiFQsSuGet/KV8HZ788hclvAl+7azx3tkM= | |||
| xorm.io/core v0.7.0/go.mod h1:TuOJjIVa7e3w/rN8tDcAvuLBMtwzdHPbyOzE6Gk1EUI= | |||
| xorm.io/core v0.7.2-0.20190928055935-90aeac8d08eb h1:msX3zG3BPl8Ti+LDzP33/9K7BzO/WqFXk610K1kYKfo= | |||
There was a problem hiding this comment.
Why is xorm.io/core v0.7.0 still referenced? Some dependency needs updating too, it seems.
There was a problem hiding this comment.
It seems github.com/lafriks/xormstore need an update.
There was a problem hiding this comment.
@lunny It would maybe cleaner to release a new version for core and xorm than using a commit reference ?
| @@ -162,3 +166,7 @@ xorm.io/builder v0.3.6 h1:ha28mQ2M+TFx96Hxo+iq6tQgnkC9IZkM6D8w9sKHHF8= | |||
| xorm.io/builder v0.3.6/go.mod h1:LEFAPISnRzG+zxaxj2vPicRwz67BdhFreKg8yv8/TgU= | |||
| xorm.io/core v0.7.0 h1:hKxuOKWZNeiFQsSuGet/KV8HZ788hclvAl+7azx3tkM= | |||
| xorm.io/core v0.7.0/go.mod h1:TuOJjIVa7e3w/rN8tDcAvuLBMtwzdHPbyOzE6Gk1EUI= | |||
| xorm.io/core v0.7.1 h1:I6x6Q6dYb67aDEoYFWr2t8UcKIYjJPyCHS+aXuj5V0Y= | |||
| xorm.io/core v0.7.1/go.mod h1:jJfd0UAEzZ4t87nbQYtVjmqpIODugN6PD2D9E+dJvdM= | |||
There was a problem hiding this comment.
Again, is it OK to have v0.7.0 and v0.7.1 still referenced here?
guillep2k
suggested changes
Sep 28, 2019
models/issue_test.go
Outdated
| var issue = Issue{ | ||
| RepoID: repo.ID, | ||
| PosterID: user.ID, | ||
| Title: "my issue1", |
There was a problem hiding this comment.
Suggested change
| Title: "my issue1", | |
| Title: title, |
models/issue_test.go
Outdated
| RepoID: repo.ID, | ||
| PosterID: user.ID, | ||
| Title: "my issue1", | ||
| Content: "special issue's comments?", |
There was a problem hiding this comment.
Suggested change
| Content: "special issue's comments?", | |
| Content: content, |
sapk
added a commit
to sapk-fork/xormstore
that referenced
this pull request
Sep 28, 2019
Related: go-gitea/gitea#8309 Commands used: GO111MODULE=on go get -u -v github.com/go-xorm/xorm@v0.7.8-0.20190928100219-d6963b7d423d GO111MODULE=on go mod tidy
|
@sapk @guillep2k done. |
sapk
approved these changes
Sep 29, 2019
GiteaBot
added
lgtm/need 1
guillep2k
approved these changes
Sep 29, 2019
GiteaBot
added
lgtm/done
|
Should fix #8301 |
Closed
lafriks
pushed a commit
to lafriks/xormstore
that referenced
this pull request
Sep 29, 2019
* Update xorm to latest bug fix Related: go-gitea/gitea#8309 Commands used: GO111MODULE=on go get -u -v github.com/go-xorm/xorm@v0.7.8-0.20190928100219-d6963b7d423d GO111MODULE=on go mod tidy * update to tagged github.com/go-xorm/xorm@v0.7.8
|
New xormstore version has been tagged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added an unit tests for newissue to confirm some special characters will not break the creating of issue.