Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce quote usage to bypass bug in git-lfs #7893

Merged
merged 2 commits into from
Aug 16, 2019

Conversation

guillep2k
Copy link
Member

Fixes #7888

This is related to git-lfs/git-lfs#3131 (comment)

@zeripath would you please test this PR on your setup? It works for me.

@guillep2k
Copy link
Member Author

guillep2k commented Aug 16, 2019

For context, in my environment I've got:

$ git-lfs version
git-lfs/2.4.2 (GitHub; linux amd64; go 1.9.4)

And the git-lfs version where they've fixed this problem (git-lfs/git-lfs#3199) is v2.6.0.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 16, 2019
@codecov-io
Copy link

codecov-io commented Aug 16, 2019

Codecov Report

Merging #7893 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7893      +/-   ##
==========================================
- Coverage   41.41%   41.41%   -0.01%     
==========================================
  Files         478      478              
  Lines       63944    63944              
==========================================
- Hits        26484    26481       -3     
- Misses      34010    34013       +3     
  Partials     3450     3450
Impacted Files Coverage Δ
modules/sync/unique_queue.go 78.57% <0%> (-10.72%) ⬇️
models/unit.go 62.16% <0%> (-5.41%) ⬇️
models/repo_list.go 73.09% <0%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bee1227...4feaad0. Read the comment docs.

@guillep2k guillep2k changed the title Reduce quote usage to bypass bug in GIT_SSH_COMMAND Reduce quote usage to bypass bug in git-lfs Aug 16, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 16, 2019
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be fine. What's the problem that's caused you to need to do this though?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 16, 2019
@guillep2k
Copy link
Member Author

uld be fine. What's the problem that's caused you to need to do this though?

I wasn't able to run integration tests; ssh would keep asking to add localhost. Even if I answered yes to every prompt, git-lfs tests failed anyway.

@zeripath zeripath merged commit de5986a into go-gitea:master Aug 16, 2019
@guillep2k guillep2k deleted the fix-git-ssh-command branch August 16, 2019 22:30
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration tests fail in local setup
5 participants