Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gitea panic #7860

Closed
2 of 7 tasks
rvillablanca opened this issue Aug 14, 2019 · 9 comments · Fixed by #8429
Closed
2 of 7 tasks

Gitea panic #7860

rvillablanca opened this issue Aug 14, 2019 · 9 comments · Fixed by #8429
Labels
type/bug
Milestone
1.9.5

Comments

@rvillablanca
Copy link
Contributor

  • Gitea version (or commit ref): 1.9.0
  • Git version: 2.11.0
  • Operating system: Debian GNU/Linux 9.6 (stretch)
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

https://gist.github.com/rvillablanca/16ca66169dd2c2ddf72bcf9afb5f511e

Description

Gitea just crashed. I don't know how this happened but it seems related with gravatar library.

Screenshots

No screenshots
@lunny lunny added the type/bug label Aug 14, 2019
@lunny
Copy link
Member

lunny commented Aug 14, 2019

Maybe @strk could give some help.

@strk
Copy link
Member

strk commented Aug 15, 2019

Someone with access to the logs can tell what paniced...

@lunny
Copy link
Member

lunny commented Aug 15, 2019 •
edited

@strk Where could we send an issue for package strk.kbt.io/projects/go/libravatar ?

@lunny
Copy link
Member

lunny commented Aug 15, 2019

It seems a lock is need for that map read and write.
image

@strk
Copy link
Member

strk commented Aug 15, 2019 via email

@rvillablanca
Copy link
Contributor Author

Is there any possibility to catch this panic ?

image

@lunny lunny added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Oct 5, 2019
@lunny
Copy link
Member

lunny commented Oct 5, 2019

It should be an upstream library problem.

@rvillablanca
Copy link
Contributor Author

rvillablanca commented Oct 5, 2019 •
edited

It should be an upstream library problem.

I agree with this, it is a known library problem but it is also shutting down gitea. I think this should be logged and handled in every request by default in all http handlers. Is it allowed for an unhandled panic to crash the whole app ?

@guillep2k
Copy link
Member

@lunny @strk I've just filed a PR in go-libravatar to address this.

guillep2k added a commit to guillep2k/gitea that referenced this issue Oct 8, 2019
@guillep2k
Update strk.kbt.io/projects/go/libravatar to latest; closes go-gitea#…
c8837f1 
…7860
@guillep2k guillep2k mentioned this issue Oct 8, 2019
Merged
@lafriks lafriks modified the milestones: 1.9.4, 1.9.5 Oct 8, 2019
@lafriks lafriks removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Oct 8, 2019
techknowlogick pushed a commit that referenced this issue Oct 8, 2019
@guillep2k @techknowlogick
Update strk.kbt.io/projects/go/libravatar to latest; closes #7860 (#8429
f05a335 
)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.9.5
Development

Successfully merging a pull request may close this issue.

Update strk.kbt.io/projects/go/libravatar to latest guillep2k/gitea
5 participants
@lunny @lafriks @strk @rvillablanca @guillep2k