Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest mssqldriver #7613

Merged
merged 5 commits into from Jul 26, 2019

Conversation

zeripath
Copy link
Contributor

New driver does not tolerate USE - handle this by closing db and reopening db in the new db

Continuation of #7294

@zeripath zeripath added this to the 1.10.0 milestone Jul 25, 2019
@codecov-io
Copy link

codecov-io commented Jul 25, 2019

Codecov Report

Merging #7613 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7613      +/-   ##
==========================================
+ Coverage   41.27%   41.27%   +<.01%     
==========================================
  Files         469      469              
  Lines       63716    63716              
==========================================
+ Hits        26299    26300       +1     
- Misses      33992    33993       +1     
+ Partials     3425     3423       -2
Impacted Files Coverage Δ
models/unit.go 62.16% <0%> (-5.41%) ⬇️
routers/repo/view.go 42.23% <0%> (-1.02%) ⬇️
models/repo_list.go 73.09% <0%> (+1.01%) ⬆️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bebc6a3...34d1e3d. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 25, 2019
@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Jul 25, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 25, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 26, 2019
@zeripath zeripath merged commit 78e5317 into go-gitea:master Jul 26, 2019
@zeripath zeripath deleted the move-to-latest-mssqldriver branch July 26, 2019 04:10
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants