replace lesshint with stylelint #7305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfranz
approved these changes
Jun 26, 2019
GiteaBot
added
the
lgtm/need 1
sapk
approved these changes
Jun 26, 2019
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## master #7305 +/- ##
==========================================
+ Coverage 41.23% 41.23% +<.01%
==========================================
Files 464 464
Lines 62846 62846
==========================================
+ Hits 25914 25915 +1
Misses 33542 33542
+ Partials 3390 3389 -1
Continue to review full report at Codecov.
|
|
conflicted |
New CSS linter which is much more powerfull than the previous one. Configuration is default but I had to remove a few rules that were throwing too many or weird errors. More importantly, the linter will exit with code 1 on errors so now our build will fail if the CSS linter fails which should eliminate linter errors being introduced without notice.
|
rebased |
lunny
added
the
topic/build
jeffliu27
pushed a commit
to jeffliu27/gitea
that referenced
this pull request
Jul 18, 2019
New CSS linter which is much more powerfull than the previous one. Configuration is default but I had to remove a few rules that were throwing too many or weird errors. More importantly, the linter will exit with code 1 on errors so now our build will fail if the CSS linter fails which should eliminate linter errors being introduced without notice.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New CSS linter which is much more powerful than the previous one. Configuration is default but I had to remove a few rules that were throwing too many or weird errors.
More importantly, the linter will exit non-zero on errors so now our build will fail if the CSS linter fails which should eliminate linter errors being introduced without notice.
I fixed all issues that came up, mostly duplicate selectors.