Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API link header #7298

Merged
merged 1 commit into from Jun 26, 2019
Merged

Fix API link header #7298

merged 1 commit into from Jun 26, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 26, 2019

I also added test for link header generation and will fix #7296

@lunny lunny added the type/bug label Jun 26, 2019
@lunny lunny added this to the 1.9.0 milestone Jun 26, 2019
@codecov-io
Copy link

Codecov Report

Merging #7298 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7298      +/-   ##
==========================================
+ Coverage   41.15%   41.21%   +0.05%     
==========================================
  Files         464      464              
  Lines       62763    62788      +25     
==========================================
+ Hits        25833    25878      +45     
+ Misses      33537    33520      -17     
+ Partials     3393     3390       -3
Impacted Files Coverage Δ
modules/context/api.go 74.78% <100%> (+19.47%) ⬆️
routers/repo/view.go 43.25% <0%> (+1.01%) ⬆️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️
models/unit.go 67.56% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5908bb1...db5c97c. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 26, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 26, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 26, 2019
@lunny lunny merged commit 42729b7 into go-gitea:master Jun 26, 2019
@lunny lunny deleted the lunny/fix_api_link_header branch June 26, 2019 08:51
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API /issues endpoint doesn't not propograte query parameters in pagination links
5 participants