Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker] Add LFS_START_SERVER option to control git-lfs support #7281

Merged
merged 2 commits into from
Jun 24, 2019

Conversation

slonopotamus
Copy link
Contributor

No description provided.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 23, 2019
@codecov-io
Copy link

codecov-io commented Jun 23, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@aa7c34c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7281   +/-   ##
=========================================
  Coverage          ?   41.17%           
=========================================
  Files             ?      464           
  Lines             ?    62761           
  Branches          ?        0           
=========================================
  Hits              ?    25839           
  Misses            ?    33528           
  Partials          ?     3394

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa7c34c...d87353d. Read the comment docs.

@slonopotamus
Copy link
Contributor Author

slonopotamus commented Jun 23, 2019

To be honest, this is far from perfect. Ideally, I'd like

  1. To be able to override any option in app.ini via environment variables without writing specific code for each of them
  2. To be able to override any option via environment variables even when /etc/gitea/conf/app.ini already exists.

But for what I am trying to achieve (start Gitea in Docker with LFS without writing app.ini), exposing LFS_START_SERVER through environment variables will be enough.

@zeripath
Copy link
Contributor

See #350

@lafriks lafriks added the type/enhancement An improvement of existing functionality label Jun 23, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 23, 2019
@zeripath zeripath added this to the 1.9.0 milestone Jun 23, 2019
@techknowlogick techknowlogick merged commit e07ff2f into go-gitea:master Jun 24, 2019
@slonopotamus slonopotamus deleted the docker-lfs branch June 24, 2019 09:06
slonopotamus added a commit to slonopotamus/git-as-svn that referenced this pull request Aug 2, 2019
slonopotamus added a commit to git-as-svn/git-as-svn that referenced this pull request Aug 2, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants