-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark theme markdown fixes #7260
Conversation
Signed-off-by: Michael Gnehr <michael@gnehr.de>
Codecov Report
@@ Coverage Diff @@
## master #7260 +/- ##
=========================================
Coverage ? 40.99%
=========================================
Files ? 462
Lines ? 62584
Branches ? 0
=========================================
Hits ? 25654
Misses ? 33567
Partials ? 3363 Continue to review full report at Codecov.
|
Signed-off-by: Michael Gnehr <michael@gnehr.de>
02246ef
to
f9afaf7
Compare
The scrollbar styling is Firefox-only as of now. Maybe we want to add site-wide dark scrollbars to the dark theme? See here for cross-browser scrollbar styling. |
@silverwind that should probably be done in other PR |
Then I suggest removing this non-portable scrollbar style here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be globally added to all scrollbars and made portable but I would better see this done in other PR
I will remove the FF scroolbar line there. Edit:
|
remove scroll bar color, to add this globally on additional PR Co-Authored-By: Lauris BH <lauris@nix.lv> Signed-off-by: Michael Gnehr <michael@gnehr.de>
0b06b85
to
2304949
Compare
done, even created seperate PR for dark theme scrollbars: #7269 |
Signed-off-by: Michael Gnehr <michael@gnehr.de>
Please restart drone build. Ty |
* fix colors in dark theme - tables inside rendered markdown Signed-off-by: Michael Gnehr <michael@gnehr.de> * fix colors in dark theme - simpleMDE rendered preview Signed-off-by: Michael Gnehr <michael@gnehr.de> * Update public/less/themes/arc-green.less remove scroll bar color, to add this globally on additional PR Co-Authored-By: Lauris BH <lauris@nix.lv> Signed-off-by: Michael Gnehr <michael@gnehr.de> * add missing class name Signed-off-by: Michael Gnehr <michael@gnehr.de>
Images
Commit 1
Commit 2
Signed-off-by: Michael Gnehr michael@gnehr.de