Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hljs unintenionally highlighting commit links #7244

Merged
merged 3 commits into from Jun 18, 2019

Conversation

silverwind
Copy link
Member

With Ref: <url> in commit body:

Before:
Screenshot 2019-06-18 at 21 22 27

After:
Screenshot 2019-06-18 at 21 22 37

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 18, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 18, 2019
@techknowlogick techknowlogick added this to the 1.9.0 milestone Jun 18, 2019
@mrsdizzie
Copy link
Member

Will need updated unit tests to match new output, but looks good otherwise!

@silverwind
Copy link
Member Author

Oops, unit tests should be fixed now.

@codecov-io
Copy link

Codecov Report

Merging #7244 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7244      +/-   ##
==========================================
- Coverage   40.98%   40.98%   -0.01%     
==========================================
  Files         462      462              
  Lines       62584    62585       +1     
==========================================
- Hits        25651    25650       -1     
+ Misses      33574    33573       -1     
- Partials     3359     3362       +3
Impacted Files Coverage Δ
modules/markup/html.go 80.71% <100%> (+0.04%) ⬆️
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
modules/log/file.go 75.52% <0%> (-2.1%) ⬇️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️
models/unit.go 67.56% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a205155...7cfa1b3. Read the comment docs.

@techknowlogick techknowlogick merged commit b209531 into go-gitea:master Jun 18, 2019
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
* fix hljs unintenionally highlighting commit links

* fix unit tests
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants