Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify issue and wiki editors #6975

Closed
ypnos opened this issue May 17, 2019 · 7 comments
Closed

Unify issue and wiki editors #6975

ypnos opened this issue May 17, 2019 · 7 comments
Labels
outdated/theme/markdown type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@ypnos
Copy link

ypnos commented May 17, 2019

This is a feature request.

Description

Right now there is a unintuitive feature discrepancy between issues and wiki pages:

It would be great if both could share one interface that is feature-complete.
@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label May 17, 2019
@Cherrg Cherrg mentioned this issue Jun 18, 2019
Closed
7 tasks
@Cherrg
Copy link
Contributor

Cherrg commented Jun 18, 2019 •
edited

sets sum the tasks up:

Wiki

Issues

  • add codemirror editor (simpleMDE) as this is near enough to an wysiwyg editor

I will add the editor to issues, but i will wait, until all features added to the wiki editor are in master branch. So I only need to copy from there. Otherwise I will have to manually look up all changes before i could reuse it the code there.

As some tasks could be done seperatly there could be smaller PRs.
I will implement some of this, and link the PRs here.

@Cherrg Cherrg mentioned this issue Jun 18, 2019
Open
Cherrg added a commit to Cherrg/gitea that referenced this issue Jun 18, 2019
@Cherrg
Add add 'write' 'preview' buttons to wiki edit like in issues
be0dceb 
affects go-gitea#6975

Signed-off-by: Michael Gnehr <michael@gnehr.de>
@Cherrg Cherrg mentioned this issue Jun 18, 2019
Merged
techknowlogick pushed a commit that referenced this issue Nov 17, 2019
@Cherrg @techknowlogick
wiki - add 'write' 'preview' buttons to wiki edit like in issues (#7241)
1c911aa 
* Add add 'write' 'preview' buttons to wiki edit like in issues

affects #6975

Signed-off-by: Michael Gnehr <michael@gnehr.de>

* update dark theme

Signed-off-by: Michael Gnehr <michael@gnehr.de>

* fix css lint warnings - missing spaces

Signed-off-by: Michael Gnehr <michael@gnehr.de>

* hide preview button on no fullscreen toolbar

Signed-off-by: Michael Gnehr <michael@gnehr.de>
@6543

This comment has been minimized.

Sign in to view
@ypnos
Copy link
Author

ypnos commented Jan 13, 2020

Can wiki pages have attached files in 1.11? I don't see it in the changelog for RC1.

@6543
Copy link
Member

6543 commented Jan 13, 2020

no they dont have attachments jet

@ypnos
Copy link
Author

ypnos commented Jan 13, 2020

The aim of this issue is a consistent behavior and feature parity between Issue and Wiki editors.

@6543
Copy link
Member

6543 commented Jan 13, 2020

lets leave it open ...

@wxiaoguang
Copy link
Contributor

The editor problem has been fixed by latest editor refactoring PR

The wiki attachment problem is duplicate: #574

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated/theme/markdown type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@lunny @wxiaoguang @noerw @ypnos @Cherrg @6543