Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E-Mail address detection should validate domain name part #6735

Closed
silverwind opened this issue Apr 24, 2019 · 0 comments · Fixed by #6739
Closed

E-Mail address detection should validate domain name part #6735

silverwind opened this issue Apr 24, 2019 · 0 comments · Fixed by #6739
Labels
type/bug
Milestone
1.8.1

Comments

@silverwind
Copy link
Member

String cra@3 is detected as a E-Mail address and rendered with a mailto: link. I think we should validate if the part after the @ is a valid domain name and only linkify if it is the case.

image
mrsdizzie added a commit to mrsdizzie/gitea that referenced this issue Apr 24, 2019
@mrsdizzie
Fix domain name pattern in email regex
652783e 
Fixes go-gitea#6735
@mrsdizzie mrsdizzie mentioned this issue Apr 24, 2019
Merged
techknowlogick pushed a commit that referenced this issue Apr 25, 2019
@mrsdizzie @techknowlogick
Fix domain name pattern in email regex (#6739)
0064535 
Fixes #6735
@lunny lunny added the type/bug label Apr 25, 2019
@lunny lunny added this to the 1.8.1 milestone Apr 25, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.8.1
Development

Successfully merging a pull request may close this issue.

Stricter domain name pattern in email regex mrsdizzie/gitea
2 participants
@lunny @silverwind