Use ctx.metas for SHA hash links #6645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since go-gitea#6273 was merged, we now have access to proper context metas always. Update SHA generated links to use these instead of urlPrefix. Update tests as well. Fixes go-gitea#4536.
lunny
approved these changes
Apr 16, 2019
GiteaBot
added
the
lgtm/need 1
zeripath
approved these changes
Apr 16, 2019
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## master #6645 +/- ##
==========================================
+ Coverage 40.53% 40.55% +0.01%
==========================================
Files 406 406
Lines 54498 54501 +3
==========================================
+ Hits 22093 22101 +8
+ Misses 29370 29363 -7
- Partials 3035 3037 +2
Continue to review full report at Codecov.
|
|
@mrsdizzie please send back port to v1.8 if it's possible since this will depend #6273 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #6273 was merged, we now have access to proper context metas always. Update SHA generated links to use these instead of urlPrefix (this was already done for issue links in previous PR).
Update tests as well.
Fixes #4536