Provide better panic handling #5902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR gitea'ises the macaron.Recovery() handler meaning that in the event of panic we get proper gitea 500 pages and the stacktrace is logged with the gitea logger. Signed-off-by: Andrew Thornton <art27@cantab.net>
Codecov Report
@@ Coverage Diff @@
## master #5902 +/- ##
==========================================
- Coverage 38.01% 37.98% -0.04%
==========================================
Files 328 329 +1
Lines 48343 48400 +57
==========================================
+ Hits 18377 18384 +7
- Misses 27326 27375 +49
- Partials 2640 2641 +1
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
techknowlogick
approved these changes
Jan 30, 2019
GiteaBot
added
lgtm/need 1
techknowlogick
added
type/bug
type/refactoring
|
The main gotcha with this PR is that the logs are no longer just stdout'd like the macaron logs. However, we shouldn't really be stdout'ing the macaron logs either - well unless we mean to, see #5667. |
lafriks
approved these changes
Jan 30, 2019
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gitea'ises the macaron.Recovery() handler meaning that in
the event of panic we get proper gitea 500 pages and the stacktrace
is logged with the Gitea logger.
It's also noted that our 500 page was not being served with the correct http status - they were currently being served with a status code of 404.
Signed-off-by: Andrew Thornton art27@cantab.net