Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

./gitea without 'web' ignores commandline flags #5065

Closed
coolaj86 opened this issue Oct 10, 2018 · 2 comments · Fixed by #5200
Closed

./gitea without 'web' ignores commandline flags #5065

coolaj86 opened this issue Oct 10, 2018 · 2 comments · Fixed by #5200
Labels
type/bug type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone
1.6.0

Comments

@coolaj86
Copy link
Contributor

coolaj86 commented Oct 10, 2018 •
edited

Bug

Command line flags are ignored when run without web, even though the CmdWeb Action is taken.

./gitea web -p 2000

./gitea -p 2000

The default behavior should probably either be to print the help message or to find a way to shim and run ./gitea as if it had been run as ./gitea web.

https://github.com/go-gitea/gitea/blob/master/main.go#L52

Proposal

I vote ./gitea should be have as ./gitea help. Thoughts?
@lafriks
Copy link
Member

lafriks commented Oct 10, 2018

it did show help by default previously but was change some time ago to current behaviour

@lafriks lafriks added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Oct 10, 2018
@coolaj86
Copy link
Contributor Author

Both a proposal AND a bug.

If it's going to do what it's doing now, we probably should make it work consistently.

@HoffmannP HoffmannP mentioned this issue Oct 27, 2018
Merged
techknowlogick pushed a commit that referenced this issue Nov 1, 2018
@HoffmannP @techknowlogick
fix: Accept web-command cli flags if web-command is commited (#5200)
584844e 
* fix: Accept web-command cli flags if web-command is commited

* Added flags of default cmd CmdWeb to app-wide flags
* If command *is* specified app-wide flags are ignored

Resolves: #5065
Signed-off-by: Berengar W. Lehr <Berengar.Lehr@kompetenztest.de>

* Removed style breaking newline

* broken windows need to be fixed
* provides requested change
@lunny lunny added this to the 1.6.0 milestone Nov 1, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

fix: Accept web-command cli flags if web-command is commited
3 participants
@lunny @coolaj86 @lafriks