Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs on passing SSH through to container #5019

Merged
merged 7 commits into from
Jan 5, 2019

Conversation

Xiol
Copy link
Contributor

@Xiol Xiol commented Oct 5, 2018

Wasn't clear how to pass SSH connections through the container, found a
few blog posts which described roughly the same procedure I've
documented here.

Credit should really go to:

Signed-off-by: Dane Elwell dane.elwell@ukfast.co.uk

Wasn't clear how to pass SSH connections through the container, found a
few blog posts which described roughly the same procedure I've
documented here.

Credit should really go to:

* https://blog.sakuragawa.moe/gitea-in-docker-container-and-sharing-ssh-with-host/
* http://www.ateijelo.com/blog/2016/07/09/share-port-22-between-docker-gogs-ssh-and-local-system

Signed-off-by: Dane Elwell <dane.elwell@ukfast.co.uk>
@codecov-io
Copy link

codecov-io commented Oct 5, 2018

Codecov Report

Merging #5019 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5019      +/-   ##
==========================================
- Coverage   37.81%   37.81%   -0.01%     
==========================================
  Files         322      322              
  Lines       47485    47485              
==========================================
- Hits        17957    17955       -2     
- Misses      26939    26942       +3     
+ Partials     2589     2588       -1
Impacted Files Coverage Δ
models/unit.go 0% <0%> (-14.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e90103...066c362. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 5, 2018
@adelowo
Copy link
Member

adelowo commented Oct 5, 2018

Fixes #4978

@techknowlogick
Copy link
Member

With the plan on removing OpenSSHD from the container, this would no longer work so I'm hesitant to add this to documentation

@techknowlogick techknowlogick added the type/docs This PR mainly updates/creates documentation label Oct 5, 2018
@lafriks
Copy link
Member

lafriks commented Oct 6, 2018

When we switch to builtin ssh we can always remove this section but while we have not switched it is still good to have it

@techknowlogick
Copy link
Member

@lafriks ok. sounds good.

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 1, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 29, 2018
Copy link
Member

@lafriks lafriks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add note somewhere that this will work only if using opensshd in container and will not work if AuthorizedKeysCommand is used with setting to disable authorized files key generation: https://github.com/go-gitea/gitea/blob/master/custom/conf/app.ini.sample#L157

@techknowlogick
Copy link
Member

@lafriks I've updated PR with changes from your feedback, please review

@techknowlogick techknowlogick merged commit cbc14df into go-gitea:master Jan 5, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants