-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs on passing SSH through to container #5019
Conversation
Wasn't clear how to pass SSH connections through the container, found a few blog posts which described roughly the same procedure I've documented here. Credit should really go to: * https://blog.sakuragawa.moe/gitea-in-docker-container-and-sharing-ssh-with-host/ * http://www.ateijelo.com/blog/2016/07/09/share-port-22-between-docker-gogs-ssh-and-local-system Signed-off-by: Dane Elwell <dane.elwell@ukfast.co.uk>
Codecov Report
@@ Coverage Diff @@
## master #5019 +/- ##
==========================================
- Coverage 37.81% 37.81% -0.01%
==========================================
Files 322 322
Lines 47485 47485
==========================================
- Hits 17957 17955 -2
- Misses 26939 26942 +3
+ Partials 2589 2588 -1
Continue to review full report at Codecov.
|
Fixes #4978 |
With the plan on removing OpenSSHD from the container, this would no longer work so I'm hesitant to add this to documentation |
When we switch to builtin ssh we can always remove this section but while we have not switched it is still good to have it |
@lafriks ok. sounds good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add note somewhere that this will work only if using opensshd in container and will not work if AuthorizedKeysCommand
is used with setting to disable authorized files key generation: https://github.com/go-gitea/gitea/blob/master/custom/conf/app.ini.sample#L157
@lafriks I've updated PR with changes from your feedback, please review |
Wasn't clear how to pass SSH connections through the container, found a
few blog posts which described roughly the same procedure I've
documented here.
Credit should really go to:
Signed-off-by: Dane Elwell dane.elwell@ukfast.co.uk