Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activating Open Collective #3821

Merged
merged 5 commits into from May 11, 2018
Merged

Activating Open Collective #3821

merged 5 commits into from May 11, 2018

Conversation

monkeywithacupcake
Copy link
Contributor

Hi, I'm making updates for Open Collective. Either you or a supporter signed this repo up for Open Collective. This pull request adds backers and sponsors from your Open Collective https://opencollective.com/gitea ❤️

It adds two badges at the top to show the latest number of backers and sponsors. It also adds placeholders so that the avatar/logo of new backers/sponsors can automatically be shown without having to update your README.md. [more info]. See how it looks on this repo.
We have also added a postinstall script to let people know after npm|yarn install that you are welcoming donations (optional). [More info]
You can also add a "Donate" button to your website and automatically show your backers and sponsors there with our widgets. Have a look here: https://opencollective.com/widgets

P.S: As with any pull request, feel free to comment or suggest changes. The only thing "required" are the placeholders on the README because we believe it's important to acknowledge the people in your community that are contributing (financially or with code!).

Thank you for your great contribution to the open source community. You are awesome! 🙌
And welcome to the open collective community! 😊

Come chat with us in the #opensource channel on https://slack.opencollective.com - great place to ask questions and share best practices with other open source sustainers!

@monkeywithacupcake
Copy link
Contributor Author

I know I did not follow the guidelines. I read them. I am using the opencollective-cli repository in the setup branch in order to onboard repositories. This allows me to automate some repetitive tasks, while still checking code, but it limits my flexibility.

NOTE: I did not change your badge - you already had a backers badge in the heading. Please feel free to use what works best for you from this PR and ignore the rest.

  • Jess

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 20, 2018
@codecov-io
Copy link

codecov-io commented Apr 20, 2018

Codecov Report

Merging #3821 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3821   +/-   ##
=======================================
  Coverage   20.27%   20.27%           
=======================================
  Files         146      146           
  Lines       29316    29316           
=======================================
  Hits         5945     5945           
  Misses      22470    22470           
  Partials      901      901

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20acbdf...e5841f7. Read the comment docs.

@lunny lunny added the type/docs This PR mainly updates/creates documentation label Apr 20, 2018
@lunny lunny added this to the 1.5.0 milestone Apr 20, 2018
package.json Outdated
"logo": "https://opencollective.com/gitea/logo.txt"
},
"scripts": {
"postinstall": "opencollective postinstall"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need opencollective in the package.json since as I understand it, the avatars/placeholders in the README.md are static and do not require any JavaScript?

I think that this does not make sense because the most Gitea users and developers won't run yarn/npm install because it is only being used for CSS AFAIK.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it isn't right for your flow, please delete /ignore it. The idea is that when users do an npm install, they would see "Like gitea? Become a backer/sponsor"

@jonasfranz
Copy link
Member

IMHO the contributors section should be integrated into the AUTHORS section since we already have a link to 'Contributors' theire.

The sponsor images do not work at my browser:
screenshot-2018-4-21 go-gitea gitea

@lafriks
Copy link
Member

lafriks commented May 6, 2018

@JonasFranzDEV fixed :)

@jonasfranz
Copy link
Member

@lafriks What do you think? Should we replace the contributor's link with those images (see picture in my last comment)?

@lafriks
Copy link
Member

lafriks commented May 6, 2018

@JonasFranzDEV I don't think we need that. We already have link to GitHub contributors graph. I think that is more than enough.

@jonasfranz
Copy link
Member

@lafriks Sponsor images are still broken since we do not have sponsors yet.

@lafriks
Copy link
Member

lafriks commented May 6, 2018

@JonasFranzDEV that's not something I can fix on our side...

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 10, 2018
@techknowlogick
Copy link
Member

LGTM

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 10, 2018
@lunny lunny merged commit aafb0ea into go-gitea:master May 11, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants