Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #361, renamed username to login #362

Merged
merged 1 commit into from Dec 7, 2016
Merged

Fix for #361, renamed username to login #362

merged 1 commit into from Dec 7, 2016

Conversation

Bwko
Copy link
Member

@Bwko Bwko commented Dec 7, 2016

No description provided.

@thibaultmeyer
Copy link
Contributor

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 7, 2016
@bkcsoft
Copy link
Member

bkcsoft commented Dec 7, 2016

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 7, 2016
@bkcsoft bkcsoft merged commit 39d0db5 into go-gitea:master Dec 7, 2016
@lunny lunny added this to the 1.0.0 milestone Dec 7, 2016
@lunny lunny mentioned this pull request Dec 7, 2016
Closed
@tboerger tboerger added the topic/ui Change the appearance of the Gitea UI label Dec 7, 2016
@richmahn
Copy link
Contributor

richmahn commented Dec 8, 2016

Any reason API is being updated (not just this PR of course, but what it is fixing) but not changed to v2? We have thousands of users/tablets with our app which logs into our Gogs/Gitea. While I understand changing "username" to "login" like Github, that breaks the API when companies like our rolled this out. Just something to remember.

@tboerger
Copy link
Member

tboerger commented Dec 9, 2016

You are right, at least it should provide a fallback with a deprecation message

@bkcsoft
Copy link
Member

bkcsoft commented Dec 9, 2016

@tboerger how do you implement deprecation messages for this? how do we know that username is used instead of login ?

@bkcsoft
Copy link
Member

bkcsoft commented Dec 9, 2016

@richmahn This was broken by a refactor in go-gogs-client a while back, I didn't really see the point in changing the api-version. it should however obviously be documented in the Changelog when 1.0 is released. 🙂

@bkcsoft
Copy link
Member

bkcsoft commented Dec 9, 2016

Also, for clients using the latest version of go-sdk this isn't a problem since the struct member haven't changed name

@tboerger
Copy link
Member

tboerger commented Dec 9, 2016

I need to search for an example we used for drone, but we have done it with a customized marshal/unmarshal

@bkcsoft
Copy link
Member

bkcsoft commented Dec 9, 2016

Well sure, for go-sdk that works... but not when they consume the API in any other way. And like I said, go-sdk havn't changed it's internal format

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Bwko @thibaultmeyer @bkcsoft @richmahn @tboerger @lunny