Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drone release publishing and test steps #348

Merged
merged 2 commits into from Dec 5, 2016
Merged

Fix drone release publishing and test steps #348

merged 2 commits into from Dec 5, 2016

Conversation

tboerger
Copy link
Member

@tboerger tboerger commented Dec 4, 2016

No description provided.

@tboerger tboerger added topic/deployment type/enhancement An improvement of existing functionality labels Dec 4, 2016
@tboerger tboerger added this to the 1.0.0 milestone Dec 4, 2016
@tboerger
Copy link
Member Author

tboerger commented Dec 4, 2016

Awesome, I've got to drop the pam support otherwise the cross compile will fail.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 4, 2016
@tboerger
Copy link
Member Author

tboerger commented Dec 4, 2016

[updater:L50:15s] + make release
[updater:L51:15s] mkdir -p dist/binaries dist/release
[updater:L52:15s] xgo -dest dist/binaries -tags 'sqlite tidb pam' -ldflags '-s -w -X "code.gitea.io/gitea/modules/setting.BuildTime=2016-12-04 10:59:36 UTC" -X "code.gitea.io/gitea/modules/setting.BuildGitHash=621a078"' -targets 'linux/*,darwin/*,windows/*' -out gitea-master code.gitea.io/gitea
[updater:L53:15s] Cross compiling code.gitea.io/gitea...
[updater:L54:15s] Fetching main repository code.gitea.io/gitea...
[updater:L55:15s] Fetching https://code.gitea.io/gitea?go-get=1
[updater:L56:16s] Parsing meta tags from https://code.gitea.io/gitea?go-get=1 (status code 200)
[updater:L57:16s] get "code.gitea.io/gitea": found meta tag main.metaImport{Prefix:"code.gitea.io/gitea", VCS:"git", RepoRoot:"https://github.com/go-gitea/gitea"} at https://code.gitea.io/gitea?go-get=1
[updater:L58:16s] code.gitea.io/gitea (download)
[updater:L59:58s] Compiling for linux/amd64...
[updater:L60:90s] Compiling for linux/386...
[updater:L61:93s] # code.gitea.io/gitea/vendor/github.com/msteinert/pam
[updater:L62:93s] /usr/bin/ld: cannot find -lpam
[updater:L63:93s] collect2: error: ld returned 1 exit status
[updater:L64:117s] 2016/12/04 23:01:18 Failed to cross compile package: exit status 2.
[updater:L65:117s] Makefile:101: recipe for target 'release-build' failed
[updater:L66:117s] make: *** [release-build] Error 1

@tboerger tboerger added the pr/wip This PR is not ready for review label Dec 5, 2016
@bkcsoft
Copy link
Member

bkcsoft commented Dec 5, 2016

well, PAM feels like a hack anyway so I'm all for dropping it 😆

@tboerger
Copy link
Member Author

tboerger commented Dec 5, 2016

I can't believe that anybody seriously uses pam anyway :)

@tboerger tboerger removed the pr/wip This PR is not ready for review label Dec 5, 2016
@tboerger
Copy link
Member Author

tboerger commented Dec 5, 2016

This should be fine for merge now. I have dropped the tidb tag because it increases the binary size by ~13MB and I have also dropped the pam build tag because this makes much trouble on cross-compiling the binaries. With the current configuration the publishing to s3 should be fixed and works reliable for our initial release and for continuously built binaries of the master branch.

@bkcsoft
Copy link
Member

bkcsoft commented Dec 5, 2016

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 5, 2016
@Bwko
Copy link
Member

Bwko commented Dec 5, 2016

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 5, 2016
@tboerger tboerger merged commit 7013432 into go-gitea:master Dec 5, 2016
@tboerger tboerger deleted the release-fixes branch December 5, 2016 13:49
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/deployment type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants