Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info from #2286, minor fixes to YAML indentation #3338

Merged
merged 5 commits into from
Feb 16, 2018
Merged

Add info from #2286, minor fixes to YAML indentation #3338

merged 5 commits into from
Feb 16, 2018

Conversation

microbug
Copy link
Contributor

@microbug microbug commented Jan 9, 2018

The information from #2286 doesn't appear to have made it to the docs; it's quite hard to find out how to set the UID and GID to access any volumes with. This can be an issue for users who aren't writing their config files from a user with UID=GID=1000. I added this information to the examples.

Also corrected a minor indentation issue with the YAML examples. Another commit is incoming for a space that I shouldn't have removed...

@codecov-io
Copy link

codecov-io commented Jan 9, 2018

Codecov Report

Merging #3338 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3338      +/-   ##
==========================================
- Coverage   35.69%   35.68%   -0.01%     
==========================================
  Files         281      281              
  Lines       40701    40701              
==========================================
- Hits        14529    14526       -3     
- Misses      24026    24027       +1     
- Partials     2146     2148       +2
Impacted Files Coverage Δ
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/repo_indexer.go 48.3% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b104ab3...13b2af5. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 9, 2018
@microbug
Copy link
Contributor Author

@techknowlogick
Copy link
Member

Can you re-push/force-push your commits so CI tries to build your branch again?

@lafriks lafriks added the type/docs This PR mainly updates/creates documentation label Jan 12, 2018
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 5, 2018
@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 8, 2018
@lafriks lafriks added this to the 1.5.0 milestone Feb 8, 2018
@lunny lunny merged commit 869d73a into go-gitea:master Feb 16, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants