-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add info from #2286, minor fixes to YAML indentation #3338
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3338 +/- ##
==========================================
- Coverage 35.69% 35.68% -0.01%
==========================================
Files 281 281
Lines 40701 40701
==========================================
- Hits 14529 14526 -3
- Misses 24026 24027 +1
- Partials 2146 2148 +2
Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Jan 9, 2018
Can you re-push/force-push your commits so CI tries to build your branch again? |
techknowlogick
approved these changes
Feb 5, 2018
tboerger
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Feb 5, 2018
sapk
approved these changes
Feb 8, 2018
tboerger
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Feb 8, 2018
appleboy
approved these changes
Feb 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The information from #2286 doesn't appear to have made it to the docs; it's quite hard to find out how to set the UID and GID to access any volumes with. This can be an issue for users who aren't writing their config files from a user with UID=GID=1000. I added this information to the examples.
Also corrected a minor indentation issue with the YAML examples. Another commit is incoming for a space that I shouldn't have removed...