Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[generate-licenses.go] Indentetion Fixment #3320

Closed
wants to merge 1 commit into from
Closed

[generate-licenses.go] Indentetion Fixment #3320

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 7, 2018

  • Files: generate-licenses.go
  • Changes: Tabs re-writed as spaces

@isidentical
[generate-licenses.go] Indentetion Fixment
fa06230 
- Files: generate-licenses.go
- Changes: Tabs re-writed as spaces
@thehowl
Copy link
Contributor

thehowl commented Jan 7, 2018

Again, go uses tabs instead of spaces. In fact, the CI fails because the code you wrote does not match that generated by go fmt, which has become a de facto standard in the go community.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 7, 2018
@strk
Copy link
Member

strk commented Jan 7, 2018

Use make fmt to comply

@techknowlogick
Copy link
Member

As the correct formatting already exists on this file (as make fmt has been run before this PR existed), is this PR needed?

@ghost ghost closed this Jan 8, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@thehowl @strk @techknowlogick @tboerger @isidentical