Skip to content

Can’t use custom URLs for authentication sources #31244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
FifoF opened this issue Jun 4, 2024 · 8 comments · Fixed by #31246
Closed

Can’t use custom URLs for authentication sources #31244

FifoF opened this issue Jun 4, 2024 · 8 comments · Fixed by #31246
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.22.1

Comments

@FifoF
Copy link

FifoF commented Jun 4, 2024

Description

Whenever I try adding a custom auth source, I can’t see the option to add a custom URL. I checked it using dev tools and the tw-hidden class hides it.

Screenshots

image

Gitea Version

v1.22

Can you reproduce the bug on the Gitea demo site?

No

Operating System

macOS 11.5.1

Browser Version

Opera GX 109.0.5097.108 (x86_64)
@FifoF FifoF added topic/ui Change the appearance of the Gitea UI type/bug labels Jun 4, 2024
@wxiaoguang

This comment was marked as outdated.

Sign in to view
@wxiaoguang
Copy link
Contributor

Hmm, regression of Remove jQuery .attr from the common admin functions (#30115)

@wxiaoguang wxiaoguang mentioned this issue Jun 4, 2024
Merged
@FifoF
Copy link
Author

FifoF commented Jun 4, 2024

Do you mean this? Maybe use "OpenID Connect" instead of "Gitea"?

image

I’m afraid not. There was a Use Custom URLs Instead of Default URLs checkbox that used to show up

@wxiaoguang wxiaoguang mentioned this issue Jun 4, 2024
Merged
@wxiaoguang
Copy link
Contributor

-> Fix admin oauth2 custom URL settings #31246

@lunny lunny added this to the 1.22.1 milestone Jun 4, 2024
@FifoF
Copy link
Author

FifoF commented Jun 4, 2024

Great work, I can’t wait!

@FifoF FifoF closed this as completed Jun 4, 2024
@wxiaoguang
Copy link
Contributor

Let's keep the issue open until the PR is merged ...

Sorry for the inconvenience and thank you very much for the report.

@wxiaoguang wxiaoguang reopened this Jun 4, 2024
wxiaoguang added a commit that referenced this issue Jun 4, 2024
@wxiaoguang
Fix admin oauth2 custom URL settings (#31246)

Verified

This commit was signed with the committer’s verified signature.
lunny Lunny Xiao
GPG key ID: C3B7C91B632F738A
Verified
Learn about vigilant mode
Loading
Loading status checks…
fcc061a 
Fix #31244
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Jun 4, 2024
@wxiaoguang @GiteaBot
Fix admin oauth2 custom URL settings (go-gitea#31246)

Verified

This commit was signed with the committer’s verified signature.
lunny Lunny Xiao
GPG key ID: C3B7C91B632F738A
Verified
Learn about vigilant mode
a9ed725 
Fix go-gitea#31244
@GiteaBot GiteaBot mentioned this issue Jun 4, 2024
Merged
wxiaoguang added a commit that referenced this issue Jun 4, 2024
@GiteaBot @wxiaoguang
Fix admin oauth2 custom URL settings (#31246) (#31247)
082600a 
Backport #31246 by wxiaoguang

Fix #31244

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@wxiaoguang
Copy link
Contributor

If you are using binary, the new nightly build is ready https://dl.gitea.com/gitea/1.22-nightly/ , it will become 1.22.1 soon.

If you are using docker .... the nightly rootful one is ready but the rootless one is not due to some network error.

You could track the build progress here https://github.com/go-gitea/gitea/commits/release/v1.22

Could you try if 1.22-nightly works well for you?

image

@FifoF
Copy link
Author

FifoF commented Jun 4, 2024

Yup it’s working, thanks a lot for the quick fix!

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.22.1
Development

Successfully merging a pull request may close this issue.

Fix admin oauth2 custom URL settings wxiaoguang/gitea
3 participants
@lunny @wxiaoguang @FifoF