Skip to content

Do not show monaco JS errors #30862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2024

Conversation

wxiaoguang
Copy link
Contributor

Fix #30861

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 5, 2024
@wxiaoguang wxiaoguang added the backport/v1.22 This PR should be backported to Gitea 1.22 label May 5, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 5, 2024
fix
@wxiaoguang wxiaoguang force-pushed the fix-monaco-editor-err branch from 11b6e7b to 219619c Compare May 5, 2024 10:23
@pull-request-size pull-request-size bot added size/M and removed size/S labels May 5, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 5, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@wxiaoguang wxiaoguang enabled auto-merge (squash) May 5, 2024 16:28
@wxiaoguang wxiaoguang merged commit 982b20d into go-gitea:main May 5, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone May 5, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 5, 2024
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label May 5, 2024
@wxiaoguang wxiaoguang deleted the fix-monaco-editor-err branch May 5, 2024 16:37
wxiaoguang added a commit that referenced this pull request May 5, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Backport #30862 by wxiaoguang

Fix #30861

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 6, 2024
* giteaofficial/main:
  Have time.js use UTC-related getters/setters (go-gitea#30857)
  Do not show monaco JS errors (go-gitea#30862)
  Fix issue/PR title edit (go-gitea#30858)
  Add result check in TestAPIEditUser (go-gitea#29674)
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull request May 19, 2024
Fix #3638

This is a manual Forgejo-specific version of the Gitea PR go-gitea/gitea#30862. The weekly Forgejo PR #3772 could not cherry-pick this commit due to conflicts (eg subsequent CodeSpell changes).

Only occurs with Webkit in Safari over eg `http://192..`. (not localhost).
See https://webkit.org/blog/10855/async-clipboard-api/

---
**Before**
![Before.jpg](/attachments/c570d030-fcce-48ea-ac96-06b624541c7b)

**After**
![After.jpg](/attachments/1a9132ab-f7f3-43a5-b3ea-37b6f2b671c4)

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3805
Reviewed-by: Otto <otto@codeberg.org>
Co-authored-by: David Davies-Payne <d2p@me.com>
Co-committed-by: David Davies-Payne <d2p@me.com>
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull request May 19, 2024
Fix #3638

This is a manual Forgejo-specific version of the Gitea PR go-gitea/gitea#30862. The weekly Forgejo PR #3772 could not cherry-pick this commit due to conflicts (eg subsequent CodeSpell changes).

Only occurs with Webkit in Safari over eg `http://192..`. (not localhost).
See https://webkit.org/blog/10855/async-clipboard-api/

---
**Before**
![Before.jpg](/attachments/c570d030-fcce-48ea-ac96-06b624541c7b)

**After**
![After.jpg](/attachments/1a9132ab-f7f3-43a5-b3ea-37b6f2b671c4)

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3805
Reviewed-by: Otto <otto@codeberg.org>
Co-authored-by: David Davies-Payne <d2p@me.com>
Co-committed-by: David Davies-Payne <d2p@me.com>
(cherry picked from commit e4c3c03)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js
Projects
None yet
4 participants