Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no edit history after editing issue's title and content #30814

Merged
merged 6 commits into from May 3, 2024
Merged

Fix no edit history after editing issue's title and content #30814

merged 6 commits into from May 3, 2024

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented May 2, 2024

Fix #30807

reuse functions in services

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 2, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 2, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels May 2, 2024
@yp05327 yp05327 marked this pull request as draft May 2, 2024 04:04
@yp05327 yp05327 marked this pull request as ready for review May 2, 2024 04:36
@yp05327 yp05327 requested a review from lunny May 2, 2024 04:41
lunny
lunny approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@lunny lunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the final answer. But as a quick fix, I think it's enough.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 2, 2024
@lunny lunny added the backport/v1.22 This PR should be backported to Gitea 1.22 label May 2, 2024
@lunny lunny added this to the 1.23.0 milestone May 2, 2024
@yp05327
Copy link
Contributor Author

yp05327 commented May 2, 2024 •
edited

I think we need a transaction to do this. But UpdateIssueByAPI is not good enough.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 3, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 3, 2024
@lunny lunny merged commit a50026e into go-gitea:main May 3, 2024
26 checks passed
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 3, 2024
@yp05327 @GiteaBot
Fix no edit history after editing issue's title and content (go-gitea…
3e2f801 
…#30814)

Fix go-gitea#30807

reuse functions in services
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 3, 2024
@GiteaBot GiteaBot mentioned this pull request May 3, 2024
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label May 3, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 3, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
6e5359c 
* giteaofficial/main: (30 commits)
  Improve grep search (go-gitea#30843)
  Don't only list code-enabled repositories when using repository API (go-gitea#30817)
  Fix no edit history after editing issue's title and content (go-gitea#30814)
  Ignore useless error message "broken pipe" (go-gitea#30801)
  Fix JS error on pull request page (go-gitea#30838)
  Fix body margin shifting with modals, fix error on project column edit (go-gitea#30831)
  Improve repo button row layout (go-gitea#30668)
  refactor: merge ListActionTasks func to action.go file (go-gitea#30811)
  Prevent automatic OAuth grants for public clients (go-gitea#30790)
  Catch and handle unallowed file type errors in issue attachment API (go-gitea#30791)
  Fix incorrect message id for releaes email (go-gitea#30825)
  Add hover outline to heatmap squares (go-gitea#30828)
  Remove external API calls in `TestPassword` (go-gitea#30716)
  Upgrade chi-binding (go-gitea#30826)
  Improve context popup rendering (go-gitea#30824)
  Fix activity heat map padding & locale (go-gitea#30823)
  Fix issue card layout (go-gitea#30800)
  Fix branch selector UI (go-gitea#30803)
  Fix rounded border for segment followed by pagination (go-gitea#30809)
  Skip gzip for some well-known compressed file types (go-gitea#30796)
  ...
silverwind pushed a commit that referenced this pull request May 3, 2024
@GiteaBot @yp05327
Fix no edit history after editing issue's title and content (#30814) (#…
a82e630 
…30845)

Backport #30814 by @yp05327

Fix #30807

reuse functions in services

Co-authored-by: yp05327 <576951401@qq.com>
@yp05327 yp05327 deleted the fix-30807 branch May 8, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

[API] No edit history shown afer editing an issue's body
4 participants
@yp05327 @lunny @wxiaoguang @GiteaBot