Improve oauth2 client "preferred username field" logic and the error handling #30622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
wxiaoguang
force-pushed
the
fix-oauth2-prefer
branch
from
7bd7aee
to
da73ac7
Compare
lunny
approved these changes
Apr 21, 2024
GiteaBot
added
lgtm/need 1
wxiaoguang
force-pushed
the
fix-oauth2-prefer
branch
from
da73ac7
to
f28aa56
Compare
pull-request-size
bot
added
size/L
github-actions
bot
added
modifies/translation
modifies/templates
wxiaoguang
changed the title
wxiaoguang
changed the title
wxiaoguang
force-pushed
the
fix-oauth2-prefer
branch
3 times, most recently
from
39e16a5
to
a517009
Compare
wxiaoguang
force-pushed
the
fix-oauth2-prefer
branch
from
a517009
to
10e6ac9
Compare
yp05327
reviewed
Apr 24, 2024
wxiaoguang
commented
Apr 24, 2024
yp05327
reviewed
Apr 24, 2024
yp05327
approved these changes
Apr 25, 2024
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 26, 2024
* giteaofficial/main: Deduplicate lfs common code (go-gitea#30704) Improve job commit description (go-gitea#30579) Improve test for TestPullCompare (go-gitea#30699) Allow to save empty comment (go-gitea#30706) [skip ci] Updated translations via Crowdin Refactor imagediff and fix regression bug (go-gitea#30694) Improve oauth2 client "preferred username field" logic and the error handling (go-gitea#30622) Fix active item in tab menu (go-gitea#30690)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow #30454
And fix #24957
When using "preferred_username", if no such field,
extractUserNameFromOAuth2(oldgetUserName) shouldn't return an error. All other USERNAME options do not return such error.And fine tune some logic and error messages, make code more stable and more friendly to end users.