Run go generate and go vet on all packages
#30529
Merged
+9
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/go
|
On the other hand, I'm pretty sure golang tools would ignore files in the well-known |
silverwind
commented
Apr 16, 2024
delvh
approved these changes
Apr 16, 2024
GiteaBot
added
lgtm/need 1
silverwind
commented
Apr 16, 2024
silverwind
commented
Apr 16, 2024
silverwind
commented
Apr 16, 2024
silverwind
commented
Apr 16, 2024
silverwind
commented
Apr 16, 2024
lunny
approved these changes
Apr 17, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 17, 2024
Fixes: go-gitea#30512 I think this does mean those tools would run on a potential `vendor` directory, but I'm not sure we really support vendoring of dependencies anymore. `release` has a `vendor` prerequisite so likely the source tarballs contain vendor files?
GiteaBot
added
backport/done
silverwind
added a commit
that referenced
this pull request
Apr 17, 2024
Backport #30529 by @silverwind Fixes: #30512 I think this does mean those tools would run on a potential `vendor` directory, but I'm not sure we really support vendoring of dependencies anymore. `release` has a `vendor` prerequisite so likely the source tarballs contain vendor files? Co-authored-by: silverwind <me@silverwind.io>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 18, 2024
* giteaofficial/main: Add an api test for updating user (go-gitea#30539) [skip ci] Updated translations via Crowdin Expose fuzzy search for issues/pulls (go-gitea#29701) Allow everyone to read or write a wiki by a repo unit setting (go-gitea#30495) Support nuspec manifest download for nuget packages (go-gitea#28921) Fix branch_protection api shows users/teams who has no readAccess (go-gitea#30291) Correct locale string rendering (go-gitea#30522) Run `go generate` and `go vet` on all packages (go-gitea#30529) Fix and tweak pull request commit list (go-gitea#30528) Refactor web routes (go-gitea#30519) Fix install page checkboxes and dropdown width (go-gitea#30526) # Conflicts: # routers/web/user/home.go # templates/user/dashboard/issues.tmpl
wxiaoguang
added
the
skip-changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #30512
I think this does mean those tools would run on a potential
vendordirectory, but I'm not sure we really support vendoring of dependencies anymore.releasehas avendorprerequisite so likely the source tarballs contain vendor files?