Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill all gitea processes before air build #30477

Merged
merged 4 commits into from Apr 15, 2024
Merged

Conversation

silverwind
Copy link
Member

So it happened to me multiple times that air leaves zombie processes after termination. I think ultimately it's some kind of bug in air, but we can work around.

The change in the delay is unrelated to the zombie processes but seems to help a bit with duplicate changes resulting in duplicate make generate as seen here:

Screenshot 2024-04-14 at 17 05 47

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 14, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 14, 2024
.air.toml Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 14, 2024
Co-authored-by: delvh <dev.lh@web.de>
.air.toml Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 15, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 15, 2024
@lunny lunny enabled auto-merge (squash) April 15, 2024 08:24
@lunny lunny merged commit 994920c into go-gitea:main Apr 15, 2024
23 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Apr 15, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 15, 2024
@silverwind silverwind deleted the kill branch April 15, 2024 08:50
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 16, 2024
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Fix various overflows on actions view (go-gitea#30344)
  Convert max file name length to 255 (go-gitea#30489)
  Remove active border on pointing menu (go-gitea#30486)
  Fix button color on red and green buttons (go-gitea#30500)
  Fix code owners will not be mentioned when a pull request comes from a forked repository (go-gitea#30476)
  Fix overflow on issue dependency (go-gitea#30484)
  Kill all gitea processes before air build (go-gitea#30477)
@wxiaoguang wxiaoguang modified the milestones: 1.23.0, 1.22.0 Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/internal size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants