Allow preferred_username as username source for OIDC
#30454
Merged
+15
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
wxiaoguang
reviewed
Apr 13, 2024
pull-request-size
bot
added
size/S
wxiaoguang
reviewed
Apr 14, 2024
delvh
changed the title
preferred_username as username source for OIDC
delvh
reviewed
Apr 14, 2024
wxiaoguang
approved these changes
Apr 15, 2024
GiteaBot
added
lgtm/need 1
SimonErm
force-pushed
the
feature/add-oidc-preferred_username-as-username-source
branch
from
03d0768
to
8e846e2
Compare
delvh
approved these changes
Apr 15, 2024
GiteaBot
added
lgtm/done
delvh
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 17, 2024
* giteaofficial/main: Reduce unnecessary database queries on actions table (go-gitea#30509) [skip ci] Updated translations via Crowdin Tweak and fix toggle checkboxes (go-gitea#30527) Tweak repo buttons on mobile and labeled button border-radius (go-gitea#30503) Fix long branch name overflows (go-gitea#30345) Update API to return 'source_id' for users (go-gitea#29718) Allow `preferred_username` as username source for OIDC (go-gitea#30454) Fix empty field `login_name` in API response JSON when creating user (go-gitea#30511) feat(api): implement branch/commit comparison API (go-gitea#30349)
wxiaoguang
added a commit
to wxiaoguang/gitea
that referenced
this pull request
Apr 21, 2024
wxiaoguang
added a commit
to wxiaoguang/gitea
that referenced
this pull request
Apr 21, 2024
wxiaoguang
added a commit
to wxiaoguang/gitea
that referenced
this pull request
Apr 21, 2024
wxiaoguang
added a commit
to wxiaoguang/gitea
that referenced
this pull request
Apr 21, 2024
wxiaoguang
added a commit
to wxiaoguang/gitea
that referenced
this pull request
Apr 23, 2024
wxiaoguang
added a commit
to wxiaoguang/gitea
that referenced
this pull request
Apr 23, 2024
wxiaoguang
added a commit
to wxiaoguang/gitea
that referenced
this pull request
Apr 23, 2024
wxiaoguang
added a commit
that referenced
this pull request
Apr 25, 2024
…handling (#30622) Follow #30454 And fix #24957 When using "preferred_username", if no such field, `extractUserNameFromOAuth2` (old `getUserName`) shouldn't return an error. All other USERNAME options do not return such error. And fine tune some logic and error messages, make code more stable and more friendly to end users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the preferred_username claim as a possible username source for the oauth2_client.
Closes #21518