Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close file in the Upload func #30262

Merged
merged 1 commit into from Apr 3, 2024
Merged

fix: close file in the Upload func #30262

merged 1 commit into from Apr 3, 2024

Conversation

testwill
Copy link
Contributor

@testwill testwill commented Apr 3, 2024 •
edited by lunny

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 3, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 3, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Apr 3, 2024
@lunny lunny added type/bug backport/v1.21 This PR should be backported to Gitea 1.21 backport/v1.22 This PR should be backported to Gitea 1.22 labels Apr 3, 2024
@lunny
Copy link
Member

lunny commented Apr 3, 2024

The Download func has the same problem.

@testwill
fix: close file in the Upload and Download func
2bea904 
Signed-off-by: guoguangwu <guoguangwug@gmail.com>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 3, 2024
lunny
lunny requested changes Apr 3, 2024
View reviewed changes
Copy link
Member

@lunny lunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per #30262 (comment)

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 3, 2024
@lng2020
Copy link
Member

lng2020 commented Apr 3, 2024

per #30262 (comment)

2bea904

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Apr 3, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 3, 2024
@techknowlogick techknowlogick merged commit 0ceecfc into go-gitea:main Apr 3, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Apr 3, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 3, 2024
@testwill @GiteaBot
fix: close file in the Upload func (go-gitea#30262)
2ef372e
@GiteaBot GiteaBot mentioned this pull request Apr 3, 2024
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 3, 2024
@testwill @GiteaBot
fix: close file in the Upload func (go-gitea#30262)
03692b1
@GiteaBot GiteaBot mentioned this pull request Apr 3, 2024
Merged
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 3, 2024
@testwill testwill deleted the file_close branch April 3, 2024 14:59
jolheiser pushed a commit that referenced this pull request Apr 3, 2024
@GiteaBot @testwill
Close file in the Upload func (#30262) (#30269)
4588c7b 
Co-authored-by: guangwu <guoguangwu@magic-shield.com>
jolheiser pushed a commit that referenced this pull request Apr 3, 2024
@GiteaBot @testwill
Close file in the Upload func (#30262) (#30270)
f45df3e 
Co-authored-by: guangwu <guoguangwu@magic-shield.com>
@GiteaBot
Copy link
Contributor

GiteaBot commented Apr 3, 2024

I was unable to create a backport for 1.21. @testwill, please send one manually. 🍵

go run ./contrib/backport 30262
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Apr 3, 2024
@GiteaBot
Copy link
Contributor

GiteaBot commented Apr 3, 2024

I was unable to create a backport for 1.22. @testwill, please send one manually. 🍵

go run ./contrib/backport 30262
...  // fix git conflicts if any
go run ./contrib/backport --continue

AvengerMoJo pushed a commit to AvengerMoJo/gitea that referenced this pull request Apr 8, 2024
@testwill @AvengerMoJo
fix: close file in the Upload func (go-gitea#30262)
f0a2687
@lunny lunny added the backport/done All backports for this PR have been created label Apr 12, 2024
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@lng2020 lng2020 lng2020 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.21 This PR should be backported to Gitea 1.21 backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@testwill @lunny @lng2020 @GiteaBot @techknowlogick @wxiaoguang