Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable eslint space-before-function-paren #30078

Merged
merged 2 commits into from Mar 25, 2024
Merged

Enable eslint space-before-function-paren #30078

merged 2 commits into from Mar 25, 2024

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Mar 25, 2024 •
edited

Anonymous are set to ignore as I couldn't decide. No current violations.

Rule docs: https://eslint.style/rules/js/space-before-function-paren

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 25, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 25, 2024
@silverwind silverwind added topic/code-linting skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. and removed modifies/internal labels Mar 25, 2024
@silverwind silverwind mentioned this pull request Mar 25, 2024
Merged
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 25, 2024
@silverwind
Copy link
Member Author

If people agree to anonymous: never, I'd gladly push it, would be a 93-line diff.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 25, 2024
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 25, 2024
@silverwind silverwind enabled auto-merge (squash) March 25, 2024 23:09
@silverwind silverwind merged commit bcb151c into go-gitea:main Mar 25, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 25, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 25, 2024
@lunny lunny modified the milestones: 1.23.0, 1.22.0 Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yardenshoham yardenshoham yardenshoham approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/internal size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/code-linting
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@silverwind @yardenshoham @delvh @lunny @GiteaBot