Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jQuery .attr from the code line range selection #30077

Merged
merged 3 commits into from Mar 25, 2024
Merged

Remove jQuery .attr from the code line range selection #30077

merged 3 commits into from Mar 25, 2024

Conversation

yardenshoham
Copy link
Member

  • Switched from jQuery attr to plain javascript getAttribute and setAttribute
  • Tested the code line range selection and it works as before

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 25, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 25, 2024
@yardenshoham
Remove jQuery .attr from the code line range selection
e0216cc 
- Switched from jQuery `.attr` to plain javascript `getAttribute` and `setAttribute`
- Tested the code line range selection and it works as before

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
@yardenshoham @silverwind
Update web_src/js/features/repo-code.js
0879a28 
Co-authored-by: silverwind <me@silverwind.io>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 25, 2024
@silverwind silverwind mentioned this pull request Mar 25, 2024
Merged
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 25, 2024
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 25, 2024
@silverwind silverwind enabled auto-merge (squash) March 25, 2024 22:58
@silverwind silverwind merged commit a9a5734 into go-gitea:main Mar 25, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 25, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 25, 2024
silverwind added a commit that referenced this pull request Mar 25, 2024
@silverwind
Enable eslint space-before-function-paren (#30078)
bcb151c 
Anonymous are set to ignore as I [couldn't
decide](#30077 (comment)).
No current violations.

Rule docs: https://eslint.style/rules/js/space-before-function-paren
@lunny lunny modified the milestones: 1.23.0, 1.22.0 Mar 26, 2024
@yardenshoham yardenshoham deleted the repo-code-jquery-attr branch March 26, 2024 09:15
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull request Mar 30, 2024
@silverwind @earl-warren
Enable eslint space-before-function-paren (#30078)
faffda0 
Anonymous are set to ignore as I [couldn't
decide](go-gitea/gitea#30077 (comment)).
No current violations.

Rule docs: https://eslint.style/rules/js/space-before-function-paren

(cherry picked from commit bcb151c220c3fa6003810e436acdda9cc0501e58)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yardenshoham @silverwind @delvh @lunny @GiteaBot