Fix misuse of TxContext
#30061
Merged
Fix misuse of TxContext
#30061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfogre
added
type/bug
backport/v1.21
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
lunny
approved these changes
Mar 25, 2024
GiteaBot
added
lgtm/need 1
Zettat123
approved these changes
Mar 25, 2024
GiteaBot
added
lgtm/done
|
We should use |
lunny
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Mar 25, 2024
Help go-gitea#29999, or its tests cannot pass. Also, add some comments to clarify the usage of `TxContext`. I don't check all usages of `TxContext` because there are too many (almost 140+). It's a better idea to replace them with `WithTx` instead of checking them one by one. However, that may be another refactoring PR.
GiteaBot
added
backport/done
wolfogre
added a commit
that referenced
this pull request
Mar 25, 2024
Backport #30061 by @wolfogre Help #29999, or its tests cannot pass. Also, add some comments to clarify the usage of `TxContext`. I don't check all usages of `TxContext` because there are too many (almost 140+). It's a better idea to replace them with `WithTx` instead of checking them one by one. However, that may be another refactoring PR. Co-authored-by: Jason Song <i@wolfogre.com>
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Mar 25, 2024
* origin/main: Remove fomantic table module (go-gitea#30047) Fix menu buttons in issues and release (go-gitea#30056) Fix git grep search limit, add test (go-gitea#30071) Fix button hover border (go-gitea#30048) Fix Add/Remove WIP on pull request title failure (go-gitea#29999) Fix misuse of `TxContext` (go-gitea#30061) Remove jQuery `.attr` from the reaction selector (go-gitea#30052) Remove jQuery `.attr` from the ComboMarkdownEditor (go-gitea#30051) Remove jQuery `.attr` from the label edit exclusive checkbox (go-gitea#30053) Remove jQuery `.attr` from the repository topic bar (go-gitea#30050) Use db.ListOptions directly instead of Paginator interface to make it easier to use and fix performance of /pulls and /issues (go-gitea#29990) Migrate `gt-hidden` to `tw-hidden` (go-gitea#30046) Forbid jQuery `is` and fix issues (go-gitea#30016) Remove fomantic segment module (go-gitea#30042) Migrate margin and padding helpers to tailwind (go-gitea#30043)
TKaxv-7S
added a commit
to TKaxv-7S/gitea
that referenced
this pull request
Apr 10, 2024
v1.21.10 * BUGFIXES * Fix Add/Remove WIP on pull request title failure (go-gitea#29999) (go-gitea#30066) * Fix misuse of `TxContext` (go-gitea#30061) (go-gitea#30062) * Respect DEFAULT_ORG_MEMBER_VISIBLE setting when adding creator to org (go-gitea#30013) (go-gitea#30035) * Escape paths for find file correctly (go-gitea#30026) (go-gitea#30031) * Remove duplicate option in admin screen and now-unused translation keys (go-gitea#28492) (go-gitea#30024) * Fix manual merge form and 404 page templates (go-gitea#30000) # gpg: Signature made Tue, Mar 26, 2024 7:48:36 AM # gpg: using EDDSA key 8722B61D72341082553B201CB8BE6D610E61C862 # gpg: Can't check signature: No public key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Help #29999, or its tests cannot pass.
Also, add some comments to clarify the usage of
TxContext.I don't check all usages of
TxContextbecause there are too many (almost 140+). It's a better idea to replace them withWithTxinstead of checking them one by one. However, that may be another refactoring PR.