Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Crowdin action for translation sync #30054

Merged
merged 7 commits into from Mar 30, 2024
Merged

Use Crowdin action for translation sync #30054

merged 7 commits into from Mar 30, 2024

Conversation

denyskon
Copy link
Member

@denyskon denyskon commented Mar 24, 2024 •
edited

Switch from the old self-built action to the official one.

We get:

  • config managed inside the repo
  • automatic upload when source file changes
  • automatic invalidation if source string changes (tested)
  • automatic download of new translation files

Tested both upload and download.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 24, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 24, 2024
@denyskon denyskon marked this pull request as draft March 24, 2024 21:19
@pull-request-size pull-request-size bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 29, 2024
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 29, 2024
@denyskon denyskon changed the title [WIP] Use Crowdin action for translation sync Use Crowdin action for translation sync Mar 29, 2024
@denyskon denyskon marked this pull request as ready for review March 29, 2024 19:16
@denyskon denyskon added this to the 1.23.0 milestone Mar 29, 2024
@denyskon denyskon added type/miscellaneous skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Mar 29, 2024
silverwind
silverwind approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets try it.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 29, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 29, 2024
@denyskon denyskon removed the request for review from techknowlogick March 30, 2024 06:56
@denyskon denyskon added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 30, 2024
@techknowlogick techknowlogick enabled auto-merge (squash) March 30, 2024 18:03
@techknowlogick techknowlogick merged commit f32ce75 into go-gitea:main Mar 30, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 30, 2024
@denyskon denyskon deleted the crowdin-action branch March 30, 2024 18:15
@silverwind
Copy link
Member

silverwind commented Mar 31, 2024 •
edited

Seems to work: bcf3be3 7eb3ab0. Last one was only 1 key update, maybe we can batch these together like daily previously.

@denyskon
Copy link
Member Author

@silverwind In terms of pull interval, there's nothing different - we just had a manually scheduled test run earlier yesterday to check if it works, otherwise this would have been one commit :)

zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 31, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
fb637f0 
* giteaofficial/main:
  Do not allow different storage configurations to point to the same directory (go-gitea#30169)
  Fix GPG subkey verify (go-gitea#30193)
  [skip ci] Updated translations via Crowdin
  Fix unclickable checkboxes (go-gitea#30195)
  Remove jQuery class from the issue author dropdown (go-gitea#30188)
  Remove jQuery class from the comment edit history (go-gitea#30186)
  Remove jQuery class from the repository branch settings (go-gitea#30184)
  [skip ci] Updated translations via Crowdin
  Use Crowdin action for translation sync (go-gitea#30054)
  Remove jQuery class from the project page (go-gitea#30183)
  Remove jQuery class from the comment context menu (go-gitea#30179)
@silverwind
Copy link
Member

Ok, then the second commit really was a day's content.

@wxiaoguang wxiaoguang modified the milestones: 1.23.0, 1.22.0 Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny left review comments

@techknowlogick techknowlogick techknowlogick left review comments

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/internal size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/miscellaneous
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@denyskon @silverwind @lunny @techknowlogick @delvh @wxiaoguang @GiteaBot