Remove fomantic table module #30047
Merged
Remove fomantic table module #30047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XXL
silverwind
added
type/refactoring
delvh
approved these changes
Mar 24, 2024
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Mar 25, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Mar 25, 2024
* origin/main: Remove fomantic table module (go-gitea#30047) Fix menu buttons in issues and release (go-gitea#30056) Fix git grep search limit, add test (go-gitea#30071) Fix button hover border (go-gitea#30048) Fix Add/Remove WIP on pull request title failure (go-gitea#29999) Fix misuse of `TxContext` (go-gitea#30061) Remove jQuery `.attr` from the reaction selector (go-gitea#30052) Remove jQuery `.attr` from the ComboMarkdownEditor (go-gitea#30051) Remove jQuery `.attr` from the label edit exclusive checkbox (go-gitea#30053) Remove jQuery `.attr` from the repository topic bar (go-gitea#30050) Use db.ListOptions directly instead of Paginator interface to make it easier to use and fix performance of /pulls and /issues (go-gitea#29990) Migrate `gt-hidden` to `tw-hidden` (go-gitea#30046) Forbid jQuery `is` and fix issues (go-gitea#30016) Remove fomantic segment module (go-gitea#30042) Migrate margin and padding helpers to tailwind (go-gitea#30043)
lunny
pushed a commit
that referenced
this pull request
Mar 26, 2024
Fix regression from #30047. Apparently tables have certain user-agent styles that center inside `<th>` etc. Restored the original fomantic rules for these. Before: <img width="1332" alt="Screenshot 2024-03-25 at 21 59 33" src="https://github.com/go-gitea/gitea/assets/115237/e06a5509-b505-4752-9b6e-91d5ed49f61d"> After: <img width="1330" alt="Screenshot 2024-03-25 at 21 59 40" src="https://github.com/go-gitea/gitea/assets/115237/6444817f-dd61-4a1e-a8b3-959c2780148d">
silverwind
added a commit
that referenced
this pull request
Mar 27, 2024
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
Mar 30, 2024
Fix regression from go-gitea/gitea#30047. Apparently tables have certain user-agent styles that center inside `<th>` etc. Restored the original fomantic rules for these. Before: <img width="1332" alt="Screenshot 2024-03-25 at 21 59 33" src="https://github.com/go-gitea/gitea/assets/115237/e06a5509-b505-4752-9b6e-91d5ed49f61d"> After: <img width="1330" alt="Screenshot 2024-03-25 at 21 59 40" src="https://github.com/go-gitea/gitea/assets/115237/6444817f-dd61-4a1e-a8b3-959c2780148d"> (cherry picked from commit dd75237c3492140140c7413d788bd961692048d8)
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
Mar 30, 2024
Fixes go-gitea/gitea#30142, regression from go-gitea/gitea#30047. I searched the codebase and only `bottom aligned` was definitely not in use so I removed it. (cherry picked from commit b08c7afe5f60075ed62a5ffe034b88624983d007)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big CSS module. I tested basic functionality on admin and commits table.