Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid jQuery is and fix issues #30016

Merged
merged 3 commits into from Mar 24, 2024
Merged

Forbid jQuery is and fix issues #30016

merged 3 commits into from Mar 24, 2024

Conversation

silverwind
Copy link
Member

Tested all functionality.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 23, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 23, 2024
@silverwind silverwind added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. modifies/internal modifies/js and removed modifies/frontend modifies/internal modifies/js labels Mar 23, 2024
yardenshoham
yardenshoham reviewed Mar 24, 2024
View reviewed changes
Copy link
Member

@yardenshoham yardenshoham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you able to thoroughly test all the changed functions?

web_src/js/features/admin/common.js Outdated Show resolved Hide resolved
@silverwind @yardenshoham
Update web_src/js/features/admin/common.js
8cb0144 
Co-authored-by: Yarden Shoham <git@yardenshoham.com>
@silverwind
Copy link
Member Author

Yes, all except the OAuth thing as I haven't found out yet when this checkbox shows.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 24, 2024
@silverwind
Copy link
Member Author

Ok it does show for GitHub type and I verified the boolean is read correctly:

image

@wxiaoguang

This comment was marked as outdated.

Sign in to view
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 24, 2024
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 24, 2024
@silverwind silverwind enabled auto-merge (squash) March 24, 2024 17:51
@silverwind
Copy link
Member Author

silverwind commented Mar 24, 2024 •
edited

According to #30016 (comment)

* If it hasn't been tested, I don't know how to approve it.

* If it has been tested, I think it's worth to rewrite to proper JS style code. It doesn't make sense to rewrite it again and test it again in the future, it just wastes time.

I'd say it depends. Trivial refactors don't need testing. If I had to test the margin/padding change everywhere, I'd go insane in the process.

@silverwind silverwind merged commit 0a2f973 into go-gitea:main Mar 24, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 24, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 24, 2024
@silverwind silverwind deleted the no-is branch March 24, 2024 18:07
silverwind added a commit to silverwind/gitea that referenced this pull request Mar 25, 2024
@silverwind
Merge remote-tracking branch 'origin/main' into cmpzero
eed565f 
* origin/main:
  Remove fomantic table module (go-gitea#30047)
  Fix menu buttons in issues and release (go-gitea#30056)
  Fix git grep search limit, add test (go-gitea#30071)
  Fix button hover border (go-gitea#30048)
  Fix Add/Remove WIP on pull request title failure (go-gitea#29999)
  Fix misuse of `TxContext` (go-gitea#30061)
  Remove jQuery `.attr` from the reaction selector (go-gitea#30052)
  Remove jQuery `.attr` from the ComboMarkdownEditor (go-gitea#30051)
  Remove jQuery `.attr` from the label edit exclusive checkbox (go-gitea#30053)
  Remove jQuery `.attr` from the repository topic bar (go-gitea#30050)
  Use db.ListOptions directly instead of Paginator interface to make it easier to use and fix performance of /pulls and /issues (go-gitea#29990)
  Migrate `gt-hidden` to `tw-hidden` (go-gitea#30046)
  Forbid jQuery `is` and fix issues (go-gitea#30016)
  Remove fomantic segment module (go-gitea#30042)
  Migrate margin and padding helpers to tailwind (go-gitea#30043)
@lunny lunny modified the milestones: 1.23.0, 1.22.0 Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@yardenshoham yardenshoham yardenshoham approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/internal modifies/js size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@silverwind @wxiaoguang @yardenshoham @lunny @GiteaBot