Remove remaining jQuery .css code #30015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
silverwind
added
type/refactoring
delvh
reviewed
Mar 23, 2024
web_src/js/features/imagediff.js
Outdated
| $range.on('input', onInput); | ||
| onInput(); | ||
| // some inner elements are `position: absolute`, so the container's height must be large enough | ||
| // the "css(width, height)" is somewhat hacky and not easy to understand, it could be improved in the future |
There was a problem hiding this comment.
That sentence no longer applies?
Suggested change
| // the "css(width, height)" is somewhat hacky and not easy to understand, it could be improved in the future |
There was a problem hiding this comment.
Anyone looking at that code knows it's hacky 😆
There was a problem hiding this comment.
Oh and sorry about merging too soon.
Co-authored-by: delvh <dev.lh@web.de>
delvh
approved these changes
Mar 23, 2024
GiteaBot
added
lgtm/need 1
wxiaoguang
approved these changes
Mar 24, 2024
GiteaBot
added
lgtm/done
silverwind
added
the
reviewed/wait-merge
wxiaoguang
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 24, 2024
* giteaofficial/main: (28 commits) Enable a few stylelint rules (go-gitea#30038) Remove remaining jQuery .css code (go-gitea#30015) Respect DEFAULT_ORG_MEMBER_VISIBLE setting when adding creator to org (go-gitea#30013) Remove jQuery `.attr` from the common global functions (go-gitea#30023) Migrate font-size helpers to tailwind (go-gitea#30029) Replace all simple inline styles with tailwind (go-gitea#30032) Migrate font-weight helpers to tailwind (go-gitea#30027) Remove jQuery from the issue "go to" button (go-gitea#30028) Determine fuzziness of bleve indexer by keyword length (go-gitea#29706) Escape paths for find file correctly (go-gitea#30026) Remove jQuery `.attr` from the diff page (go-gitea#30021) Remove jQuery `.attr` from the repository settings (go-gitea#30018) Remove jQuery `.attr` from the image diff again (go-gitea#30022) Introduce `.secondary-nav` and handle `.page-content` spacing universally (go-gitea#29982) Remove jQuery `.attr` from the branch/tag selector (go-gitea#30010) Remove jQuery `.attr` from the commit graph (go-gitea#30006) Remove jQuery from the citation modal (except fomantic) (go-gitea#30008) Remove jQuery `.attr` from the project page (go-gitea#30004) Fix incorrect tailwind migration (go-gitea#30007) Enforce trailing comma in JS on multiline (go-gitea#30002) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linter missed these because they were set on a object. Tested and I also renamed those properties to add
$indicating a jQuery selection.