Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always support repo code search even if the indexer is not enabled #29996

Closed
arbitrary-dev opened this issue Mar 22, 2024 · 9 comments · Fixed by #29998
Closed

Always support repo code search even if the indexer is not enabled #29996

arbitrary-dev opened this issue Mar 22, 2024 · 9 comments · Fixed by #29998
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail

Comments

@arbitrary-dev
Copy link

arbitrary-dev commented Mar 22, 2024

Feature Description

Here it says that Gitea supports "Repository code search":
https://docs.gitea.com/installation/comparison?_highlight=repository&_highlight=code&_highlight=search#code-management

Yet I was disappointed, when I couldn't find one on a running testing instance browsing a couple of repos:
https://try.gitea.io/

Please add it.

Screenshots

No response

@arbitrary-dev arbitrary-dev added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Mar 22, 2024
@lunny
Copy link
Member

lunny commented Mar 22, 2024

The try site and default instances haven't enabled it. You can try in your self-hosted instances.

@lunny lunny added issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail and removed type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Mar 22, 2024
@arbitrary-dev
Copy link
Author

The try site and default instances haven't enabled it.

Why so?

And, is there anywhere in the docs a description on how to enable it?

@lunny
Copy link
Member

lunny commented Mar 22, 2024

https://docs.gitea.com/administration/repo-indexer?_highlight=indexer#setting-up-the-repository-indexer

@lunny lunny closed this as completed Mar 22, 2024
@6543
Copy link
Member

6543 commented Mar 22, 2024

@arbitrary-dev be aware your text is formulated harsh and unfreandly ... exactly the "demand"ing part!

This is a foss project, if you want to demand anything you can only do so if you have a contract by paying (not donating by the way ...) witch you dont!

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Mar 22, 2024

Actually I am writing one: Support repo code search without external indexer #29998


And I agree with 6543, since this is an open source community, it's better to put oneself in someone else's shoes and think as the contributors & volunteers

@wxiaoguang wxiaoguang reopened this Mar 22, 2024
@wxiaoguang wxiaoguang changed the title I demand code search feature! Always support repo code search even if the indexer is not enabled Mar 22, 2024
@arbitrary-dev
Copy link
Author

Cool, thanks! @wxiaoguang

Then it seems like the current documentation is a bit ambiguous on the topic.
It says "Repository code search: ✓", when in reality it is:

Repository code search: ✓ *

* external indexer required


Some people just need to grow up and stop being offended by mere words :)

@wxiaoguang
Copy link
Contributor

Here is Gitea Community Code of Conduct, we encourage to use positive and "welcoming and inclusive language"

https://github.com/go-gitea/gitea/blob/main/CODE_OF_CONDUCT.md

@6543
Copy link
Member

6543 commented Mar 23, 2024

external indexer required

Thats wrong you can set belve as indexer witch is compiled in ...

@arbitrary-dev
Copy link
Author

witch

*which

silverwind added a commit that referenced this issue Mar 24, 2024
By using git's ability, end users (especially small instance users) do
not need to enable the indexer, they could also benefit from the code
searching feature.

Fix #29996


![image](https://github.com/go-gitea/gitea/assets/2114189/11b7e458-88a4-480d-b4d7-72ee59406dd1)


![image](https://github.com/go-gitea/gitea/assets/2114189/0fe777d5-c95c-4288-a818-0427680805b6)

---------

Co-authored-by: silverwind <me@silverwind.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants