Use db.ListOptions directly instead of Paginator interface to make it easier to use and fix performance of /pulls and /issues #29990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
type/bug
type/refactoring
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
github-actions
bot
added
modifies/api
pull-request-size
bot
added
size/M
github-actions
bot
removed
the
modifies/api
6543
approved these changes
Mar 22, 2024
GiteaBot
added
lgtm/need 1
lunny
changed the title
silverwind
approved these changes
Mar 24, 2024
GiteaBot
added
lgtm/done
|
No backport needed imho. |
6543
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
The performance of /pulls and /issues have been regression in v1.21. This PR will fix it. Maybe we can partially back port just for the performance. |
|
I was unable to create a backport for 1.21. @lunny, please send one manually. 🍵 |
GiteaBot
added
the
backport/manual
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Mar 25, 2024
* origin/main: Remove fomantic table module (go-gitea#30047) Fix menu buttons in issues and release (go-gitea#30056) Fix git grep search limit, add test (go-gitea#30071) Fix button hover border (go-gitea#30048) Fix Add/Remove WIP on pull request title failure (go-gitea#29999) Fix misuse of `TxContext` (go-gitea#30061) Remove jQuery `.attr` from the reaction selector (go-gitea#30052) Remove jQuery `.attr` from the ComboMarkdownEditor (go-gitea#30051) Remove jQuery `.attr` from the label edit exclusive checkbox (go-gitea#30053) Remove jQuery `.attr` from the repository topic bar (go-gitea#30050) Use db.ListOptions directly instead of Paginator interface to make it easier to use and fix performance of /pulls and /issues (go-gitea#29990) Migrate `gt-hidden` to `tw-hidden` (go-gitea#30046) Forbid jQuery `is` and fix issues (go-gitea#30016) Remove fomantic segment module (go-gitea#30042) Migrate margin and padding helpers to tailwind (go-gitea#30043)
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Apr 12, 2024
… easier to use and fix performance of /pulls and /issues (go-gitea#29990) This PR uses `db.ListOptions` instead of `Paginor` to make the code simpler. And it also fixed the performance problem when viewing /pulls or /issues. Before the counting in fact will also do the search. --------- Co-authored-by: Jason Song <i@wolfogre.com> Co-authored-by: silverwind <me@silverwind.io>
silverwind
added a commit
that referenced
this pull request
Apr 13, 2024
…easier to use and fix performance of /pulls and /issues (#29990) (#30447) backport #29990 This PR uses `db.ListOptions` instead of `Paginor` to make the code simpler. And it also fixed the performance problem when viewing /pulls or /issues. Before the counting in fact will also do the search. Co-authored-by: Jason Song <i@wolfogre.com> Co-authored-by: silverwind <me@silverwind.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses
db.ListOptionsinstead ofPaginorto make the code simpler.And it also fixed the performance problem when viewing /pulls or /issues. Before the counting in fact will also do the search.