Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add muted class to author name in repo commit list #29989

Merged

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Mar 22, 2024

Before:
image

After:
image

If repo is a mirror, external user's name will be white, but if user is existed, then you will see blue names and white names together:
image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 22, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 22, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Mar 22, 2024
@yp05327 yp05327 added the topic/ui Change the appearance of the Gitea UI label Mar 22, 2024
@silverwind
Copy link
Member

silverwind commented Mar 22, 2024

There is inconsistent margin betwen avatar and text in your second screenshot. Does .author-wrapper fix that? Generally I think it could use like 2px-3px more margin.

@delvh
Copy link
Member

delvh commented Mar 22, 2024

I haven't quite understood, when will the name be displayed in blue?
To me, it looks like it will always be white…

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 22, 2024
@silverwind
Copy link
Member

silverwind commented Mar 22, 2024

Yes, make it always muted please and add a bit margin. Mixed color looks inconsistent.

@yp05327
Copy link
Contributor Author

yp05327 commented Mar 25, 2024

There is inconsistent margin between avatar and text in your second screenshot.

It is caused by these unknow spaces. Where does these spaces come from?
image
image
image

@silverwind
Copy link
Member

silverwind commented Mar 25, 2024

HTML inter-tag whitespace, we can make it insignficant by setting display: flex I assume.

@silverwind
Copy link
Member

Pushed a margin increase:

image

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 25, 2024
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 25, 2024
@silverwind silverwind enabled auto-merge (squash) March 25, 2024 19:51
@silverwind silverwind merged commit 1392156 into go-gitea:main Mar 25, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 25, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 25, 2024
@yp05327 yp05327 deleted the add-muted-class-to-author-name-in-commit-list branch March 26, 2024 00:02
@lunny lunny modified the milestones: 1.23.0, 1.22.0 Mar 26, 2024
@yp05327
Copy link
Contributor Author

yp05327 commented Mar 27, 2024

HTML inter-tag whitespace, we can make it insignficant by setting display: flex I assume.

image
flex caused username is not in the middle
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants